remove http routes

Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>

packages/backend-app-api/package.json

@@ -48,8 +48,7 @@
   "dependencies": {
     "@backstage/backend-plugin-api": "workspace:^",
     "@backstage/config": "workspace:^",
-    "@backstage/errors": "workspace:^",
-    "express-promise-router": "^4.1.0"
+    "@backstage/errors": "workspace:^"
   },
   "devDependencies": {
     "@backstage/backend-defaults": "workspace:^",

packages/backend-app-api/src/wiring/BackendInitializer.test.ts

@@ -32,9 +32,6 @@ const baseFactories = [
   mockServices.lifecycle.factory(),
   mockServices.rootLogger.factory(),
   mockServices.logger.factory(),
-  mockServices.rootConfig.factory(),
-  mockServices.rootHttpRouter.mock().factory,
-  mockServices.rootHealth.factory(),
 ];
 
 function mkNoopFactory(ref: ServiceRef<{}, 'plugin'>) {

packages/backend-app-api/src/wiring/BackendInitializer.ts

@@ -42,7 +42,6 @@ import { createInitializationLogger } from './createInitializationLogger';
 import { unwrapFeature } from './helpers';
 // eslint-disable-next-line @backstage/no-relative-monorepo-imports
 import type { InstanceMetadataServicePluginInfo } from '../../../backend-plugin-api/src/services/definitions/InstanceMetadataService';
-import Router from 'express-promise-router';
 
 export interface BackendRegisterInit {
   consumes: Set<ServiceOrExtensionPoint>;
@@ -133,10 +132,9 @@ function createInstanceMetadataServiceFactory(
   return createServiceFactory({
     service: coreServices.instanceMetadata,
     deps: {
-      httpRouter: coreServices.rootHttpRouter,
       logger: coreServices.rootLogger,
     },
-    factory: async ({ logger, httpRouter }) => {
+    factory: async ({ logger }) => {
       const instanceMetadata = {
         getInstalledPlugins: () => Object.values(installedPlugins),
       };
@@ -147,14 +145,6 @@ function createInstanceMetadataServiceFactory(
           .map(p => p.pluginId)
           .join(', ')}`,
       );
-
-      const router = Router();
-
-      router.get('/info', (_, res) => {
-        res.json({ plugins: Object.values(installedPlugins) });
-      });
-
-      httpRouter.use('/.backstage/instanceMetadata/v1', router);
       return instanceMetadata;
     },
   });

yarn.lock

@@ -2518,7 +2518,6 @@ __metadata:
     "@backstage/cli": "workspace:^"
     "@backstage/config": "workspace:^"
     "@backstage/errors": "workspace:^"
-    express-promise-router: "npm:^4.1.0"
   languageName: unknown
   linkType: soft