review comments

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
This commit is contained in:
Fredrik Adelöw
2024-06-11 08:53:24 +02:00
parent cd1e5bf33d
commit 3c7dbc0091
2 changed files with 4 additions and 4 deletions
@@ -76,7 +76,7 @@ describe('GcsUrlReader', () => {
});
it('check if userAgent has been called with this key value', async () => {
const getStorage: any = {
userAgent: `backstage/backend-common.GoogleGcsUrlReader/${packageinfo.version}`,
userAgent: `backstage/backend-defaults.GoogleGcsUrlReader/${packageinfo.version}`,
};
jest.mock('@google-cloud/storage', () => {
return {
@@ -85,7 +85,7 @@ describe('GcsUrlReader', () => {
});
const getUserAgent = getStorage.userAgent.toString();
expect(getUserAgent).toBe(
`backstage/backend-common.GoogleGcsUrlReader/${packageinfo.version}`,
`backstage/backend-defaults.GoogleGcsUrlReader/${packageinfo.version}`,
);
});
@@ -70,7 +70,7 @@ export class GoogleGcsUrlReader implements UrlReaderService {
'googleGcs credentials not found in config. Using default credentials provider.',
);
storage = new GoogleCloud.Storage({
userAgent: `backstage/backend-common.GoogleGcsUrlReader/${packageinfo.version}`,
userAgent: `backstage/backend-defaults.GoogleGcsUrlReader/${packageinfo.version}`,
});
} else {
storage = new GoogleCloud.Storage({
@@ -78,7 +78,7 @@ export class GoogleGcsUrlReader implements UrlReaderService {
client_email: gcsConfig.clientEmail || undefined,
private_key: gcsConfig.privateKey || undefined,
},
userAgent: `backstage/backend-common.GoogleGcsUrlReader/${packageinfo.version}`,
userAgent: `backstage/backend-defaults.GoogleGcsUrlReader/${packageinfo.version}`,
});
}
const reader = new GoogleGcsUrlReader(gcsConfig, storage);