fixed comments from benjdlambert

Signed-off-by: Luka Siric <siric.luka@gmail.com>

.changeset/fast-paws-press.md

@@ -1,6 +1,6 @@
 ---
 '@backstage/cli': patch
-'@backstage/core-app-api': patch
+'@backstage/core-app-api': minor
 ---
 
 Added support for custom certificate for webpack dev server.

app-config.yaml

@@ -3,11 +3,11 @@ app:
   baseUrl: http://localhost:3000
   googleAnalyticsTrackingId: # UA-000000-0
   # https:
-  #   credentials:
+  #   certificate:
   #     cert:
-  #       $file '\path\to\the\certificate'
+  #       $file: '\path\to\the\certificate'
   #     key:
-  #       $file '\path\to\the\private-key'
+  #       $file: '\path\to\the\private-key'
   #datadogRum:
   #  clientToken: '123456789'
   #  applicationId: qwerty

packages/cli/src/lib/bundler/server.ts

@@ -40,6 +40,7 @@ export async function serveBundle(options: ServeOptions) {
     isDev: true,
     baseUrl: url,
   });
+
   const compiler = webpack(config);
 
   const server = new WebpackDevServer(
@@ -64,10 +65,10 @@ export async function serveBundle(options: ServeOptions) {
         url.protocol === 'https:'
           ? {
               cert: options.frontendConfig.getOptionalString(
-                'app.https.credentials.cert',
+                'app.https.certificate.cert',
               ),
               key: options.frontendConfig.getOptionalString(
-                'app.https.credentials.key',
+                'app.https.certificate.key',
               ),
             }
           : false,

packages/core-app-api/config.d.ts

@@ -72,14 +72,14 @@ export interface Config {
       /**
        * Parent object containing certificate and the private key
        */
-      credentials?: {
+      certificate?: {
         /**
-         * Https Certificate private key. Can be loaded using $file
+         * Https Certificate private key. Use $file to load in a file
          * @visibility frontend
          */
         key?: string;
         /**
-         * Https Certificate. Can be loaded using $file
+         * Https Certificate. Use $file to load in a file
          * @visibility frontend
          */
         cert?: string;