fix(scaffolder-backend-module-github): createOrUpdateEnvironmentSecret missing owner and repo
Signed-off-by: Diego Iglesias <diegohi@gmail.com>
This commit is contained in:
@@ -2,4 +2,4 @@
|
||||
'@backstage/plugin-scaffolder-backend-module-github': patch
|
||||
---
|
||||
|
||||
Fixed issue with octokit call missing owner and repo when creating environment variables using github:environment:create action
|
||||
Fixed issue with octokit call missing owner and repo when creating environment variables and secrets using github:environment:create action
|
||||
|
||||
+4
@@ -245,6 +245,8 @@ describe('github:environment:create examples', () => {
|
||||
mockOctokit.rest.actions.createOrUpdateEnvironmentSecret,
|
||||
).toHaveBeenCalledWith({
|
||||
repository_id: 'repoid',
|
||||
owner: 'owner',
|
||||
repo: 'repository',
|
||||
environment_name: 'envname',
|
||||
secret_name: 'secret1',
|
||||
key_id: 'keyid',
|
||||
@@ -254,6 +256,8 @@ describe('github:environment:create examples', () => {
|
||||
mockOctokit.rest.actions.createOrUpdateEnvironmentSecret,
|
||||
).toHaveBeenCalledWith({
|
||||
repository_id: 'repoid',
|
||||
owner: 'owner',
|
||||
repo: 'repository',
|
||||
environment_name: 'envname',
|
||||
secret_name: 'secret2',
|
||||
key_id: 'keyid',
|
||||
|
||||
@@ -286,6 +286,8 @@ describe('github:environment:create', () => {
|
||||
mockOctokit.rest.actions.createOrUpdateEnvironmentSecret,
|
||||
).toHaveBeenCalledWith({
|
||||
repository_id: 'repoid',
|
||||
owner: 'owner',
|
||||
repo: 'repository',
|
||||
environment_name: 'envname',
|
||||
secret_name: 'key1',
|
||||
key_id: 'keyid',
|
||||
@@ -295,6 +297,8 @@ describe('github:environment:create', () => {
|
||||
mockOctokit.rest.actions.createOrUpdateEnvironmentSecret,
|
||||
).toHaveBeenCalledWith({
|
||||
repository_id: 'repoid',
|
||||
owner: 'owner',
|
||||
repo: 'repository',
|
||||
environment_name: 'envname',
|
||||
secret_name: 'key2',
|
||||
key_id: 'keyid',
|
||||
|
||||
@@ -220,6 +220,8 @@ export function createGithubEnvironmentAction(options: {
|
||||
|
||||
await client.rest.actions.createOrUpdateEnvironmentSecret({
|
||||
repository_id: repository.data.id,
|
||||
owner: owner,
|
||||
repo: repo,
|
||||
environment_name: name,
|
||||
secret_name: key,
|
||||
encrypted_value: encryptedBase64Secret,
|
||||
|
||||
Reference in New Issue
Block a user