Merge pull request #11104 from backstage/freben/less-true-than-before

most of these casts are apparently no longer necessary

docs/auth/add-auth-provider.md

@@ -74,7 +74,7 @@ export class ProviderAAuthProvider implements OAuthProviderHandlers {
         clientID: options.clientId,
         clientSecret: options.clientSecret,
         callbackURL: options.callbackUrl,
-        passReqToCallback: false as true,
+        passReqToCallback: false,
         response_type: 'code',
         /// ... etc
       }

plugins/auth-backend/src/providers/auth0/provider.ts

@@ -71,6 +71,8 @@ export class Auth0AuthProvider implements OAuthHandlers {
         clientSecret: options.clientSecret,
         callbackURL: options.callbackUrl,
         domain: options.domain,
+        // We need passReqToCallback set to false to get params, but there's
+        // no matching type signature for that, so instead behold this beauty
         passReqToCallback: false as true,
       },
       (

plugins/auth-backend/src/providers/bitbucket/provider.ts

@@ -94,9 +94,7 @@ export class BitbucketAuthProvider implements OAuthHandlers {
         clientID: options.clientId,
         clientSecret: options.clientSecret,
         callbackURL: options.callbackUrl,
-        // We need passReqToCallback set to false to get params, but there's
-        // no matching type signature for that, so instead behold this beauty
-        passReqToCallback: false as true,
+        passReqToCallback: false,
       },
       (
         accessToken: any,

plugins/auth-backend/src/providers/google/provider.ts

@@ -73,9 +73,7 @@ export class GoogleAuthProvider implements OAuthHandlers {
         clientID: options.clientId,
         clientSecret: options.clientSecret,
         callbackURL: options.callbackUrl,
-        // We need passReqToCallback set to false to get params, but there's
-        // no matching type signature for that, so instead behold this beauty
-        passReqToCallback: false as true,
+        passReqToCallback: false,
       },
       (
         accessToken: any,

plugins/auth-backend/src/providers/microsoft/provider.ts

@@ -83,7 +83,7 @@ export class MicrosoftAuthProvider implements OAuthHandlers {
         callbackURL: options.callbackUrl,
         authorizationURL: options.authorizationUrl,
         tokenURL: options.tokenUrl,
-        passReqToCallback: false as true,
+        passReqToCallback: false,
       },
       (
         accessToken: any,

plugins/auth-backend/src/providers/oauth2/provider.ts

@@ -76,7 +76,7 @@ export class OAuth2AuthProvider implements OAuthHandlers {
         callbackURL: options.callbackUrl,
         authorizationURL: options.authorizationUrl,
         tokenURL: options.tokenUrl,
-        passReqToCallback: false as true,
+        passReqToCallback: false,
         scope: options.scope,
         customHeaders: options.includeBasicAuth
           ? {

plugins/auth-backend/src/providers/oidc/provider.ts

@@ -146,7 +146,7 @@ export class OidcAuthProvider implements OAuthHandlers {
     const strategy = new OidcStrategy(
       {
         client,
-        passReqToCallback: false as true,
+        passReqToCallback: false,
       },
       (
         tokenset: TokenSet,

plugins/auth-backend/src/providers/okta/provider.ts

@@ -94,7 +94,7 @@ export class OktaAuthProvider implements OAuthHandlers {
         clientSecret: options.clientSecret,
         callbackURL: options.callbackUrl,
         audience: options.audience,
-        passReqToCallback: false as true,
+        passReqToCallback: false,
         store: this.store,
         response_type: 'code',
       },

plugins/auth-backend/src/providers/onelogin/provider.ts

@@ -71,7 +71,7 @@ export class OneLoginProvider implements OAuthHandlers {
         clientID: options.clientId,
         clientSecret: options.clientSecret,
         callbackURL: options.callbackUrl,
-        passReqToCallback: false as true,
+        passReqToCallback: false,
       },
       (
         accessToken: any,