fix tsc errors

Signed-off-by: Andrew Ochsner <andrew.ochsner@cognizant.com>

.changeset/wet-vans-drive.md

@@ -1,5 +1,7 @@
 ---
 '@backstage/plugin-scaffolder-backend': minor
+'@backstage/plugin-catalog-backend-module-github': patch
+'@backstage/integration': patch
 ---
 
-Add support for Repository Variables and Secrets to the `publish:github` and `github:repo:create` scaffolder actions.
+Add support for Repository Variables and Secrets to the `publish:github` and `github:repo:create` scaffolder actions. Upgrade octokit introduces some breaking changes.

packages/integration/src/github/SingleInstanceGithubCredentialsProvider.ts

@@ -174,8 +174,10 @@ class GithubAppManager {
     const allInstallations = await this.getInstallations();
     const installation = allInstallations.find(
       inst =>
-        inst.account?.login?.toLocaleLowerCase('en-US') ===
-        owner.toLocaleLowerCase('en-US'),
+        inst.account &&
+        'login' in inst.account &&
+        inst.account.login?.toLocaleLowerCase('en-US') ===
+          owner.toLocaleLowerCase('en-US'),
     );
     if (installation) {
       return {

plugins/catalog-backend-module-github/src/processors/GithubMultiOrgReaderProcessor.ts

@@ -233,6 +233,7 @@ export class GithubMultiOrgReaderProcessor implements CatalogProcessor {
       .map(install =>
         install.target_type === 'Organization' &&
         install.account &&
+        'login' in install.account &&
         install.account.login
           ? {
               name: install.account.login,

plugins/catalog-backend-module-github/src/providers/GithubMultiOrgEntityProvider.ts

@@ -838,6 +838,7 @@ export class GithubMultiOrgEntityProvider implements EntityProvider {
       .map(install =>
         install.target_type === 'Organization' &&
         install.account &&
+        'login' in install.account &&
         install.account.login
           ? install.account.login
           : undefined,

plugins/scaffolder-backend/package.json

@@ -87,7 +87,7 @@
     "morgan": "^1.10.0",
     "node-fetch": "^2.6.7",
     "nunjucks": "^3.2.3",
-    "octokit": "^2.0.5",
+    "octokit": "^2.0.0",
     "octokit-plugin-create-pull-request": "^3.10.0",
     "p-limit": "^3.1.0",
     "p-queue": "^6.6.2",

yarn.lock

@@ -8263,7 +8263,7 @@ __metadata:
     msw: ^1.0.0
     node-fetch: ^2.6.7
     nunjucks: ^3.2.3
-    octokit: ^2.0.5
+    octokit: ^2.0.0
     octokit-plugin-create-pull-request: ^3.10.0
     p-limit: ^3.1.0
     p-queue: ^6.6.2
@@ -32189,7 +32189,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"octokit@npm:^2.0.4, octokit@npm:^2.0.5":
+"octokit@npm:^2.0.0, octokit@npm:^2.0.4":
   version: 2.0.18
   resolution: "octokit@npm:2.0.18"
   dependencies: