Fix repetitive error reporting in EntityTypePicker

Signed-off-by: Fredrik Adelöw <freben@gmail.com>

.changeset/giant-meals-smile.md

@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-catalog-react': patch
+---
+
+Fix repetitive error reporting in EntityTypePicker

plugins/catalog-react/src/components/EntityTypePicker/EntityTypePicker.tsx

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import React from 'react';
+import React, { useEffect } from 'react';
 import { capitalize } from 'lodash';
 import { Box } from '@material-ui/core';
 import { useEntityTypeFilter } from '../../hooks/useEntityTypeFilter';
@@ -26,13 +26,16 @@ export const EntityTypePicker = () => {
   const alertApi = useApi(alertApiRef);
   const { error, types, selectedType, setType } = useEntityTypeFilter();
 
-  if (!types) return null;
+  useEffect(() => {
+    if (error) {
+      alertApi.post({
+        message: `Failed to load entity types`,
+        severity: 'error',
+      });
+    }
+  }, [error, alertApi]);
 
-  if (error) {
-    alertApi.post({
-      message: `Failed to load entity types`,
-      severity: 'error',
-    });
+  if (!types || error) {
     return null;
   }