Fix Dockerfile comments and README instructions

This commit is contained in:
Alisina Bahadori
2020-09-20 23:32:17 +03:30
parent 5d8afa9bc6
commit 357a99a20b
2 changed files with 3 additions and 8 deletions
@@ -1,10 +1,5 @@
FROM node:12 AS build
# This dockerfile does not require the app to be built on the host machine.
# simply builds backstage in node image then transfers compiled files to nginx container.
# You can build this image with `docker build -f Dockerfile.standalone -t backstage .`
RUN mkdir /app
COPY . /app
WORKDIR /app
@@ -12,7 +7,7 @@ WORKDIR /app
RUN yarn install
RUN yarn workspace example-app build
# Contruct backstage image
# Contruct backstage-frontend image
FROM nginx:mainline
RUN apt-get update && apt-get -y install jq && rm -rf /var/lib/apt/lists/*
@@ -9,11 +9,11 @@ You can simply run the following command to build backstage.
```
# Make sure you are in the root directory of backstage then run
docker build -t backstage -f ./contrib/docker/multi-stage-frontend/Dockerfile .
docker build -t backstage-frontend -f ./contrib/docker/multi-stage-frontend/Dockerfile .
```
After a successful build, You can simply run backstage frontend with the following command.
```
docker run -it --rm -p 3080:80 backstage
docker run -it --rm -p 3080:80 backstage-frontend
```