auth-backend: some review feedback of oidc bits

plugins/auth-backend/src/identity/TokenFactory.ts

@@ -67,7 +67,7 @@ export class TokenFactory implements TokenIssuer {
     const iss = this.issuer;
     const sub = params.claims.sub;
     const aud = 'backstage';
-    const iat = (Date.now() / MS_IN_S) | 0;
+    const iat = Math.floor(Date.now() / MS_IN_S);
     const exp = iat + this.keyDuration * MS_IN_S;
 
     this.logger.info(`Issuing token for ${sub}`);

plugins/auth-backend/src/identity/router.ts

@@ -15,17 +15,15 @@
  */
 
 import Router from 'express-promise-router';
-import { Logger } from 'winston';
 import { TokenIssuer } from './types';
 
 export type Options = {
-  logger: Logger;
   baseUrl: string;
   tokenIssuer: TokenIssuer;
 };
 
 export function createOidcRouter(options: Options) {
-  const { logger, tokenIssuer, baseUrl } = options;
+  const { baseUrl, tokenIssuer } = options;
 
   const router = Router();
 
@@ -44,23 +42,19 @@ export function createOidcRouter(options: Options) {
   };
 
   router.get('/.well-known/openid-configuration', (_req, res) => {
-    logger.info('request configuration');
     res.json(config);
   });
 
   router.get('/.well-known/jwks.json', async (_req, res) => {
-    logger.info('request certs');
     const { keys } = await tokenIssuer.listPublicKeys();
     res.json({ keys });
   });
 
   router.get('/v1/token', (_req, res) => {
-    logger.info('request token');
     res.status(501).send('Not Implemented');
   });
 
   router.get('/v1/userinfo', (_req, res) => {
-    logger.info('request userinfo');
     res.status(501).send('Not Implemented');
   });
 

plugins/auth-backend/src/service/router.ts

@@ -112,7 +112,6 @@ export async function createRouter(
 
   router.use(
     createOidcRouter({
-      logger: logger.child({ component: 'oidc-router' }),
       tokenIssuer,
       baseUrl,
     }),