paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 44 Packages Projects Releases Wiki Activity

feat(catalog-backend-module-github): rename options_ to wrappedOptions

Browse Source 
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
This commit is contained in:
MT Lewis
2026-05-19 13:41:49 +01:00
parent d745f1c39c
commit 340977de5e
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/catalog-backend-module-github/src/lib/github.ts
+8 -7
View File
@@ -1047,23 +1047,24 @@ function installConditionalRequestCache(
octokit: Octokit,
cache: CacheService,
): void {
octokit.hook.wrap('request', async (request, options_) => {
const resolvedUrl = (options_.url || '').replace(/\{([^}]+)\}/g, (_, key) =>
encodeURIComponent((options_ as any)[key]),
octokit.hook.wrap('request', async (request, wrappedOptions) => {
const resolvedUrl = (wrappedOptions.url || '').replace(
/\{([^}]+)\}/g,
(_, key) => encodeURIComponent((wrappedOptions as any)[key]),
);
const cacheKey = `catalog-backend-module-github:${options_.method}:${options_.baseUrl}${resolvedUrl}`;
const cacheKey = `catalog-backend-module-github:${wrappedOptions.method}:${wrappedOptions.baseUrl}${resolvedUrl}`;
const cached = await cache
.get<CachedGitHubResponse>(cacheKey)
.catch(() => undefined);
if (cached?.lastModified) {
options_.headers['if-modified-since'] = cached.lastModified;
wrappedOptions.headers['if-modified-since'] = cached.lastModified;
} else if (cached?.etag) {
options_.headers['if-none-match'] = cached.etag;
wrappedOptions.headers['if-none-match'] = cached.etag;
}
try {
const response = await request(options_);
const response = await request(wrappedOptions);
const lastModified = response.headers['last-modified'];
const etag = response.headers.etag;