Merge pull request #33782 from UsainBloot/feat/extension-point-middleware

feat(backend): add extensionPointFactoryMiddleware to createBackend
This commit is contained in:
Patrik Oldsberg
2026-04-15 01:00:53 +02:00
committed by GitHub
20 changed files with 432 additions and 20 deletions
@@ -0,0 +1,5 @@
---
'@backstage/backend-app-api': minor
---
Added `ExtensionPointFactoryMiddleware` type and `createExtensionPointFactoryMiddleware` helper to reimplement extension point outputs at backend creation time.
@@ -0,0 +1,5 @@
---
'@backstage/backend-defaults': patch
---
Exported `defaultServiceFactories` to allow use with `createSpecializedBackend` for advanced configuration like `extensionPointFactoryMiddleware`.
+15
View File
@@ -5,6 +5,7 @@
```ts
import { BackendFeature } from '@backstage/backend-plugin-api';
import { CustomErrorBase } from '@backstage/errors';
import { ExtensionPoint } from '@backstage/backend-plugin-api';
import { ServiceFactory } from '@backstage/backend-plugin-api';
// @public (undocumented)
@@ -42,6 +43,12 @@ export interface BackendStartupResult {
resultAt: Date;
}
// @public
export function createExtensionPointFactoryMiddleware<T>(options: {
extensionPoint: ExtensionPoint<T>;
middleware: (original: T) => Promise<T>;
}): ExtensionPointFactoryMiddleware;
// @public (undocumented)
export function createSpecializedBackend(
options: CreateSpecializedBackendOptions,
@@ -51,6 +58,14 @@ export function createSpecializedBackend(
export interface CreateSpecializedBackendOptions {
// (undocumented)
defaultServiceFactories: ServiceFactory[];
// (undocumented)
extensionPointFactoryMiddleware?: ExtensionPointFactoryMiddleware[];
}
// @public
export interface ExtensionPointFactoryMiddleware {
// (undocumented)
$$type: '@backstage/ExtensionPointFactoryMiddleware';
}
// @public
@@ -28,6 +28,7 @@ import {
import { BackendInitializer } from './BackendInitializer';
import { mockServices } from '@backstage/backend-test-utils';
import { BackendStartupError } from './BackendStartupError';
import { createExtensionPointFactoryMiddleware } from './types';
const baseFactories = [
mockServices.rootLifecycle.factory(),
@@ -2111,4 +2112,218 @@ describe('BackendInitializer', () => {
);
});
});
describe('extensionPointFactoryMiddleware', () => {
it('should apply middleware to matching extension points', async () => {
expect.assertions(1);
const extensionPoint = createExtensionPoint<{ values: string[] }>({
id: 'test.ext',
});
const init = new BackendInitializer(baseFactories, [
createExtensionPointFactoryMiddleware({
extensionPoint,
middleware: async original => ({
...original,
values: [...original.values, 'from-middleware'],
}),
}),
]);
init.add(testPlugin);
init.add(
createBackendModule({
pluginId: 'test',
moduleId: 'provider',
register(reg) {
reg.registerExtensionPoint(extensionPoint, {
values: ['original'],
});
reg.registerInit({ deps: {}, async init() {} });
},
}),
);
init.add(
createBackendModule({
pluginId: 'test',
moduleId: 'consumer',
register(reg) {
reg.registerInit({
deps: { ext: extensionPoint },
async init({ ext }) {
expect(ext.values).toEqual(['original', 'from-middleware']);
},
});
},
}),
);
await init.start();
});
it('should not affect non-matching extension points', async () => {
expect.assertions(1);
const extensionPointA = createExtensionPoint<{ values: string[] }>({
id: 'test.a',
});
const extensionPointB = createExtensionPoint<{ values: string[] }>({
id: 'test.b',
});
const init = new BackendInitializer(baseFactories, [
createExtensionPointFactoryMiddleware({
extensionPoint: extensionPointA,
middleware: async original => ({
...original,
values: [...original.values, 'wrapped'],
}),
}),
]);
init.add(testPlugin);
init.add(
createBackendModule({
pluginId: 'test',
moduleId: 'provider',
register(reg) {
reg.registerExtensionPoint(extensionPointB, {
values: ['untouched'],
});
reg.registerInit({ deps: {}, async init() {} });
},
}),
);
init.add(
createBackendModule({
pluginId: 'test',
moduleId: 'consumer',
register(reg) {
reg.registerInit({
deps: { ext: extensionPointB },
async init({ ext }) {
expect(ext.values).toEqual(['untouched']);
},
});
},
}),
);
await init.start();
});
it('should chain multiple middlewares for the same extension point', async () => {
expect.assertions(1);
const extensionPoint = createExtensionPoint<{ values: string[] }>({
id: 'test.ext',
});
const init = new BackendInitializer(baseFactories, [
createExtensionPointFactoryMiddleware({
extensionPoint,
middleware: async original => ({
...original,
values: [...original.values, 'first'],
}),
}),
createExtensionPointFactoryMiddleware({
extensionPoint,
middleware: async original => ({
...original,
values: [...original.values, 'second'],
}),
}),
]);
init.add(testPlugin);
init.add(
createBackendModule({
pluginId: 'test',
moduleId: 'provider',
register(reg) {
reg.registerExtensionPoint(extensionPoint, { values: ['base'] });
reg.registerInit({ deps: {}, async init() {} });
},
}),
);
init.add(
createBackendModule({
pluginId: 'test',
moduleId: 'consumer',
register(reg) {
reg.registerInit({
deps: { ext: extensionPoint },
async init({ ext }) {
expect(ext.values).toEqual(['base', 'first', 'second']);
},
});
},
}),
);
await init.start();
});
it('should not fail when middleware targets an unregistered extension point', async () => {
const unregisteredExtensionPoint = createExtensionPoint<{
values: string[];
}>({
id: 'test.unregistered',
});
const init = new BackendInitializer(baseFactories, [
createExtensionPointFactoryMiddleware({
extensionPoint: unregisteredExtensionPoint,
middleware: async original => ({
...original,
values: [...original.values, 'never-applied'],
}),
}),
]);
init.add(testPlugin);
const { result } = await init.start();
expect(result.outcome).toBe('success');
});
it('should pass through when no middleware is provided', async () => {
expect.assertions(1);
const extensionPoint = createExtensionPoint<{ values: string[] }>({
id: 'test.ext',
});
const init = new BackendInitializer(baseFactories);
init.add(testPlugin);
init.add(
createBackendModule({
pluginId: 'test',
moduleId: 'provider',
register(reg) {
reg.registerExtensionPoint(extensionPoint, { values: ['orig'] });
reg.registerInit({ deps: {}, async init() {} });
},
}),
);
init.add(
createBackendModule({
pluginId: 'test',
moduleId: 'consumer',
register(reg) {
reg.registerInit({
deps: { ext: extensionPoint },
async init({ ext }) {
expect(ext.values).toEqual(['orig']);
},
});
},
}),
);
await init.start();
});
});
});
@@ -25,7 +25,11 @@ import {
createServiceFactory,
ExtensionPointFactoryContext,
} from '@backstage/backend-plugin-api';
import { ServiceOrExtensionPoint } from './types';
import {
ExtensionPointFactoryMiddleware,
ServiceOrExtensionPoint,
} from './types';
import { OpaqueExtensionPointFactoryMiddleware } from '@internal/backend';
// Direct internal import to avoid duplication
// eslint-disable-next-line @backstage/no-relative-monorepo-imports
import type {
@@ -166,11 +170,17 @@ export class BackendInitializer {
#serviceRegistry: ServiceRegistry;
#registeredFeatures = new Array<Promise<BackendFeature>>();
#registeredFeatureLoaders = new Array<InternalBackendFeatureLoader>();
#extensionPointFactoryMiddleware: ExtensionPointFactoryMiddleware[];
#unhandledRejectionHandler?: (reason: Error) => void;
#uncaughtExceptionHandler?: (error: Error) => void;
constructor(defaultApiFactories: ServiceFactory[]) {
constructor(
defaultApiFactories: ServiceFactory[],
extensionPointFactoryMiddleware?: ExtensionPointFactoryMiddleware[],
) {
this.#serviceRegistry = ServiceRegistry.create([...defaultApiFactories]);
this.#extensionPointFactoryMiddleware =
extensionPointFactoryMiddleware ?? [];
}
async #getInitDeps(
@@ -195,18 +205,18 @@ export class BackendInitializer {
`Rejected dependency on extension point ${ref.id} from outside of a module`,
);
}
result.set(
name,
ep.factory({
reportModuleStartupFailure: ({ error }) => {
resultCollector.amendPluginModuleResult(
pluginId,
moduleId,
error,
);
},
}),
);
let epImpl = ep.factory({
reportModuleStartupFailure: ({ error }) => {
resultCollector.amendPluginModuleResult(pluginId, moduleId, error);
},
});
for (const mw of this.#extensionPointFactoryMiddleware) {
const internal = OpaqueExtensionPointFactoryMiddleware.toInternal(mw);
if (internal.extensionPointId === ref.id) {
epImpl = await internal.middleware(epImpl);
}
}
result.set(name, epImpl);
} else {
const impl = await this.#serviceRegistry.get(
ref as ServiceRef<unknown>,
@@ -17,13 +17,23 @@
import { BackendFeature, ServiceFactory } from '@backstage/backend-plugin-api';
import { BackendInitializer } from './BackendInitializer';
import { unwrapFeature } from './helpers';
import { Backend, BackendStartupResult } from './types';
import {
Backend,
BackendStartupResult,
ExtensionPointFactoryMiddleware,
} from './types';
export class BackstageBackend implements Backend {
#initializer: BackendInitializer;
constructor(defaultServiceFactories: ServiceFactory[]) {
this.#initializer = new BackendInitializer(defaultServiceFactories);
constructor(
defaultServiceFactories: ServiceFactory[],
extensionPointFactoryMiddleware?: ExtensionPointFactoryMiddleware[],
) {
this.#initializer = new BackendInitializer(
defaultServiceFactories,
extensionPointFactoryMiddleware,
);
}
add(feature: BackendFeature | Promise<{ default: BackendFeature }>): void {
@@ -43,5 +43,8 @@ export function createSpecializedBackend(
);
}
return new BackstageBackend(options.defaultServiceFactories);
return new BackstageBackend(
options.defaultServiceFactories,
options.extensionPointFactoryMiddleware,
);
}
@@ -17,9 +17,11 @@
export type {
Backend,
CreateSpecializedBackendOptions,
ExtensionPointFactoryMiddleware,
BackendStartupResult,
PluginStartupResult,
ModuleStartupResult,
} from './types';
export { createExtensionPointFactoryMiddleware } from './types';
export { createSpecializedBackend } from './createSpecializedBackend';
export { BackendStartupError } from './BackendStartupError';
@@ -20,6 +20,34 @@ import {
ServiceRef,
ServiceFactory,
} from '@backstage/backend-plugin-api';
import { OpaqueExtensionPointFactoryMiddleware } from '@internal/backend';
/**
* A middleware entry that reimplements a specific extension point's output.
* The framework matches by extension point ID and passes through all
* non-matching extension points automatically.
*
* @public
*/
export interface ExtensionPointFactoryMiddleware {
$$type: '@backstage/ExtensionPointFactoryMiddleware';
}
/**
* Creates a typed middleware entry that reimplements a specific extension point.
* Use this helper to preserve type inference for the middleware callback.
*
* @public
*/
export function createExtensionPointFactoryMiddleware<T>(options: {
extensionPoint: ExtensionPoint<T>;
middleware: (original: T) => Promise<T>;
}): ExtensionPointFactoryMiddleware {
return OpaqueExtensionPointFactoryMiddleware.createInstance('v1', {
extensionPointId: options.extensionPoint.id,
middleware: options.middleware as (original: unknown) => Promise<unknown>,
});
}
/**
* @public
@@ -35,6 +63,7 @@ export interface Backend {
*/
export interface CreateSpecializedBackendOptions {
defaultServiceFactories: ServiceFactory[];
extensionPointFactoryMiddleware?: ExtensionPointFactoryMiddleware[];
}
/**
+4
View File
@@ -5,10 +5,14 @@
```ts
import { Backend } from '@backstage/backend-app-api';
import { BackendFeature } from '@backstage/backend-plugin-api';
import { ServiceFactory } from '@backstage/backend-plugin-api';
// @public (undocumented)
export function createBackend(): Backend;
// @public (undocumented)
export const defaultServiceFactories: ServiceFactory[];
// @public
export const discoveryFeatureLoader: BackendFeature;
```
@@ -15,6 +15,7 @@
*/
import { Backend, createSpecializedBackend } from '@backstage/backend-app-api';
import { ServiceFactory } from '@backstage/backend-plugin-api';
import { auditorServiceFactory } from '@backstage/backend-defaults/auditor';
import { authServiceFactory } from '@backstage/backend-defaults/auth';
import { cacheServiceFactory } from '@backstage/backend-defaults/cache';
@@ -42,7 +43,8 @@ import {
} from '@backstage/backend-defaults/alpha';
import { instanceMetadataServiceFactory } from './alpha/entrypoints/instanceMetadata/instanceMetadataServiceFactory';
export const defaultServiceFactories = [
/** @public */
export const defaultServiceFactories: ServiceFactory[] = [
auditorServiceFactory,
authServiceFactory,
cacheServiceFactory,
+1 -1
View File
@@ -20,5 +20,5 @@
* @packageDocumentation
*/
export { createBackend } from './CreateBackend';
export { createBackend, defaultServiceFactories } from './CreateBackend';
export { discoveryFeatureLoader } from './discoveryFeatureLoader';
+1
View File
@@ -0,0 +1 @@
module.exports = require('@backstage/cli/config/eslint-factory')(__dirname);
+3
View File
@@ -0,0 +1,3 @@
# @internal/backend
This is an internal package used by the other backend packages. It does not get published to NPM, but instead inlined into consuming packages due to the `backstage.inline` flag in `package.json`.
@@ -0,0 +1,9 @@
apiVersion: backstage.io/v1alpha1
kind: Component
metadata:
name: internal-backend
title: '@internal/backend'
spec:
lifecycle: experimental
type: backstage-node-library
owner: framework-maintainers
+28
View File
@@ -0,0 +1,28 @@
{
"name": "@internal/backend",
"version": "0.0.1",
"backstage": {
"role": "node-library",
"inline": true
},
"private": true,
"repository": {
"type": "git",
"url": "https://github.com/backstage/backstage",
"directory": "packages/backend-internal"
},
"license": "Apache-2.0",
"sideEffects": false,
"main": "src/index.ts",
"types": "src/index.ts",
"files": [
"dist"
],
"scripts": {
"lint": "backstage-cli package lint",
"test": "backstage-cli package test"
},
"devDependencies": {
"@backstage/cli": "workspace:^"
}
}
+17
View File
@@ -0,0 +1,17 @@
/*
* Copyright 2026 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
export { OpaqueExtensionPointFactoryMiddleware } from './wiring';
@@ -0,0 +1,29 @@
/*
* Copyright 2026 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { OpaqueType } from '@internal/opaque';
export const OpaqueExtensionPointFactoryMiddleware = OpaqueType.create<{
public: { $$type: '@backstage/ExtensionPointFactoryMiddleware' };
versions: {
readonly version: 'v1';
readonly extensionPointId: string;
readonly middleware: (original: unknown) => Promise<unknown>;
};
}>({
type: '@backstage/ExtensionPointFactoryMiddleware',
versions: ['v1'],
});
@@ -0,0 +1,17 @@
/*
* Copyright 2026 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
export { OpaqueExtensionPointFactoryMiddleware } from './OpaqueExtensionPointFactoryMiddleware';
+8
View File
@@ -10089,6 +10089,14 @@ __metadata:
languageName: node
linkType: hard
"@internal/backend@workspace:packages/backend-internal":
version: 0.0.0-use.local
resolution: "@internal/backend@workspace:packages/backend-internal"
dependencies:
"@backstage/cli": "workspace:^"
languageName: unknown
linkType: soft
"@internal/cli@workspace:packages/cli-internal":
version: 0.0.0-use.local
resolution: "@internal/cli@workspace:packages/cli-internal"