Merge pull request #2317 from spotify/rugvip/nolibc

cli: make skipLibCheck default in tsconfig, but provide tsc:full

.github/workflows/ci.yml

@@ -76,7 +76,7 @@ jobs:
         run: yarn lerna -- run lint --since origin/master
 
       - name: type checking and declarations
-        run: yarn tsc --incremental false
+        run: yarn tsc:full
 
       - name: build changed packages
         if: ${{ steps.yarn-lock.outcome == 'success' }}

.github/workflows/master-win.yml

@@ -43,7 +43,7 @@ jobs:
         run: yarn lerna -- run lint
 
       - name: type checking and declarations
-        run: yarn tsc --incremental false
+        run: yarn tsc:full
 
       - name: verify type dependencies
         run: yarn lint:type-deps

.github/workflows/master.yml

@@ -51,7 +51,7 @@ jobs:
         run: yarn lerna -- run lint
 
       - name: type checking and declarations
-        run: yarn tsc --incremental false
+        run: yarn tsc:full
 
       - name: build
         run: yarn build

docs/getting-started/development-environment.md

@@ -65,6 +65,7 @@ yarn storybook # Start local storybook, useful for working on components in @bac
 yarn workspace @backstage/plugin-welcome start # Serve welcome plugin only, also supports --check
 
 yarn tsc # Run typecheck, use --watch for watch mode
+yarn tsc:full # Run full type checking, for example without skipLibCheck, use in CI
 
 yarn build # Build published versions of packages, depends on tsc
 

package.json

@@ -10,6 +10,7 @@
     "start-backend": "yarn workspace example-backend start",
     "build": "lerna run build",
     "tsc": "tsc",
+    "tsc:full": "tsc --skipLibCheck false --incremental false",
     "clean": "backstage-cli clean && lerna run clean",
     "diff": "lerna run diff --",
     "test": "lerna run test --since origin/master -- --coverage",

packages/cli/config/tsconfig.json

@@ -25,6 +25,7 @@
     "removeComments": false,
     "resolveJsonModule": true,
     "sourceMap": false,
+    "skipLibCheck": true,
     "strict": true,
     "strictBindCallApply": true,
     "strictFunctionTypes": true,

packages/create-app/templates/default-app/package.json.hbs

@@ -9,6 +9,7 @@
     "start": "yarn workspace app start",
     "build": "lerna run build",
     "tsc": "tsc",
+    "tsc:full": "tsc --skipLibCheck false --incremental false",
     "clean": "backstage-cli clean && lerna run clean",
     "diff": "lerna run diff --",
     "test": "lerna run test --since origin/master -- --coverage",

packages/create-app/templates/default-app/tsconfig.json

@@ -9,7 +9,6 @@
   "exclude": ["node_modules"],
   "compilerOptions": {
     "outDir": "dist-types",
-    "rootDir": ".",
-    "skipLibCheck": true
+    "rootDir": "."
   }
 }