Merge pull request #526 from spotify/feat/issues/523

Remove the default export from plugins

packages/app/src/plugins.ts

@@ -13,7 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { default as HomePagePlugin } from '@backstage/plugin-home-page';
-import { default as WelcomePlugin } from '@backstage/plugin-welcome';
-import { default as LighthousePlugin } from '@backstage/plugin-lighthouse';
-export { HomePagePlugin, WelcomePlugin, LighthousePlugin };
+export { plugin as HomePagePlugin } from '@backstage/plugin-home-page';
+export { plugin as WelcomePlugin } from '@backstage/plugin-welcome';
+export { plugin as LighthousePlugin } from '@backstage/plugin-lighthouse';

packages/cli/src/commands/create-plugin/createPlugin.ts

@@ -122,7 +122,7 @@ export async function addPluginToApp(rootDir: string, pluginName: string) {
     .split('-')
     .map(name => capitalize(name))
     .join('');
-  const pluginImport = `import { default as ${pluginNameCapitalized} } from '${pluginPackage}';`;
+  const pluginImport = `import { plugin as ${pluginNameCapitalized} } from '${pluginPackage}';`;
   const pluginExport = `export { ${pluginNameCapitalized} };`;
   const pluginsFilePath = 'packages/app/src/plugins.ts';
   const pluginsFile = resolvePath(rootDir, pluginsFilePath);

packages/cli/templates/default-app/packages/app/src/plugins.ts

@@ -1 +1 @@
-export { default as WelcomePlugin } from 'plugin-welcome';
+export { plugin as WelcomePlugin } from 'plugin-welcome';

packages/cli/templates/default-app/plugins/welcome/src/index.ts

@@ -1 +1 @@
-export { default } from './plugin';
+export { plugin } from './plugin';

packages/cli/templates/default-app/plugins/welcome/src/plugin.test.ts

@@ -1,4 +1,4 @@
-import plugin from './plugin';
+import { plugin } from './plugin';
 
 describe('welcome', () => {
   it('should export plugin', () => {

packages/cli/templates/default-app/plugins/welcome/src/plugin.ts

@@ -1,7 +1,7 @@
 import { createPlugin } from '@backstage/core';
 import WelcomePage from './components/WelcomePage';
 
-export default createPlugin({
+export const plugin = createPlugin({
   id: 'welcome',
   register({ router }) {
     router.registerRoute('/', WelcomePage);

packages/cli/templates/default-plugin/src/index.ts

@@ -14,4 +14,4 @@
  * limitations under the License.
  */
 
-export { default } from './plugin';
+export { plugin } from './plugin';

packages/cli/templates/default-plugin/src/plugin.test.ts.hbs

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import plugin from './plugin';
+import { plugin } from './plugin';
 
 describe('{{ id }}', () => {
   it('should export plugin', () => {

packages/cli/templates/default-plugin/src/plugin.ts.hbs

@@ -17,7 +17,7 @@
 import { createPlugin } from '@backstage/core';
 import ExampleComponent from './components/ExampleComponent';
 
-export default createPlugin({
+export const plugin = createPlugin({
   id: '{{ id }}',
   register({ router }) {
     router.registerRoute('/{{ id }}', ExampleComponent);

plugins/home-page/src/index.ts

@@ -14,4 +14,4 @@
  * limitations under the License.
  */
 
-export { default } from './plugin';
+export { plugin } from './plugin';

plugins/home-page/src/plugin.test.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import plugin from './plugin';
+import { plugin } from './plugin';
 
 describe('home-page', () => {
   it('should export plugin', () => {

plugins/home-page/src/plugin.ts

@@ -17,7 +17,7 @@
 import { createPlugin } from '@backstage/core';
 import HomePage from 'components/HomePage';
 
-export default createPlugin({
+export const plugin = createPlugin({
   id: 'home-page',
   register({ router }) {
     router.registerRoute('/home', HomePage);

plugins/lighthouse/src/index.ts

@@ -14,5 +14,5 @@
  * limitations under the License.
  */
 
-export { default } from './plugin';
+export { plugin } from './plugin';
 export * from './api';

plugins/lighthouse/src/plugin.test.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import plugin from './plugin';
+import { plugin } from './plugin';
 
 describe('lighthouse', () => {
   it('should export plugin', () => {

plugins/lighthouse/src/plugin.ts

@@ -19,7 +19,7 @@ import AuditList from './components/AuditList';
 import AuditView from './components/AuditView';
 import CreateAudit from './components/CreateAudit';
 
-export default createPlugin({
+export const plugin = createPlugin({
   id: 'lighthouse',
   register({ router }) {
     router.registerRoute('/lighthouse', AuditList);

plugins/welcome/src/index.ts

@@ -14,4 +14,4 @@
  * limitations under the License.
  */
 
-export { default } from './plugin';
+export { plugin } from './plugin';

plugins/welcome/src/plugin.test.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import plugin from './plugin';
+import { plugin } from './plugin';
 
 describe('welcome', () => {
   it('should export plugin', () => {

plugins/welcome/src/plugin.ts

@@ -17,7 +17,7 @@
 import { createPlugin } from '@backstage/core';
 import WelcomePage from 'components/WelcomePage';
 
-export default createPlugin({
+export const plugin = createPlugin({
   id: 'welcome',
   register({ router, featureFlags }) {
     router.registerRoute('/', WelcomePage);