Merge pull request #3657 from adamdmharvey/lgtm-review

Address three LGTM/Semmle code scanning findings

.changeset/poor-spies-grin.md

@@ -0,0 +1,5 @@
+---
+'@backstage/config': patch
+---
+
+Fix unneeded defensive code

.changeset/seven-tigers-mate.md

@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-catalog-backend': patch
+---
+
+Fix string template literal

.changeset/violet-windows-run.md

@@ -0,0 +1,5 @@
+---
+'@backstage/config': patch
+---
+
+Fix useless conditional

packages/config/src/reader.ts

@@ -272,23 +272,17 @@ export class ConfigReader implements Config {
     if (value === undefined) {
       return this.fallback?.readConfigValue(key, validate);
     }
-    if (value !== undefined) {
-      const result = validate(value);
-      if (result !== true) {
-        const {
-          key: keyName = key,
-          value: theValue = value,
+    const result = validate(value);
+    if (result !== true) {
+      const { key: keyName = key, value: theValue = value, expected } = result;
+      throw new TypeError(
+        errors.type(
+          this.fullKey(keyName),
+          this.context,
+          typeOf(theValue),
           expected,
-        } = result;
-        throw new TypeError(
-          errors.type(
-            this.fullKey(keyName),
-            this.context,
-            typeOf(theValue),
-            expected,
-          ),
-        );
-      }
+        ),
+      );
     }
 
     return value as T;

plugins/catalog-backend/src/ingestion/processors/microsoftGraph/client.ts

@@ -184,7 +184,7 @@ export class MicrosoftGraphClient {
     const response = await this.requestApi(`organization/${tenantId}`);
 
     if (response.status !== 200) {
-      await this.handleError('organization/${tenantId}', response);
+      await this.handleError(`organization/${tenantId}`, response);
     }
 
     return await response.json();

plugins/catalog/src/components/EntityPageLayout/Tabbed/Tabbed.tsx

@@ -39,8 +39,8 @@ const getSelectedIndexOrDefault = (
 
 /**
  * Compound component, which allows you to define layout
- * for EntityPage using Tabs as a subnavigation mechanism
- * Constists of 2 parts: Tabbed.Layout and Tabbed.Content.
+ * for EntityPage using Tabs as a sub-navigation mechanism
+ * Consists of 2 parts: Tabbed.Layout and Tabbed.Content.
  * Takes care of: tabs, routes, document titles, spacing around content
  *
  * @example

plugins/catalog/src/components/Router.tsx

@@ -50,7 +50,7 @@ const EntityPageSwitch = ({ EntityPage }: { EntityPage: ComponentType }) => {
   const { entity, loading, error } = useEntity();
   // Loading and error states
   if (loading) return <EntityPageLayout />;
-  if (error || (!loading && !entity)) return <EntityNotFound />;
+  if (error || !entity) return <EntityNotFound />;
 
   // Otherwise EntityPage provided from the App
   // Note that EntityPage will include EntityPageLayout already