paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 30 Packages Projects Releases Wiki Activity

review fixes

Browse Source
This commit is contained in:
Raghunandan
2020-06-12 14:40:06 +02:00
parent 5f13a53c6a
commit 2c6b8659d3
3 changed files with 22 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/auth-backend/src/lib/OAuthProvider.test.ts
+20 -24
View File
@@ -217,11 +217,10 @@ describe('OAuthProvider', () => {
});
it('sets the refresh cookie if refresh is enabled', async () => {
oAuthProviderOptions.disableRefresh = false;
const oauthProvider = new OAuthProvider(
providerInstance,
oAuthProviderOptions,
);
const oauthProvider = new OAuthProvider(providerInstance, {
...oAuthProviderOptions,
disableRefresh: false,
});
const mockRequest = ({
cookies: {
@@ -251,11 +250,10 @@ describe('OAuthProvider', () => {
});
it('does not set the refresh cookie if refresh is disabled', async () => {
oAuthProviderOptions.disableRefresh = true;
const oauthProvider = new OAuthProvider(
providerInstance,
oAuthProviderOptions,
);
const oauthProvider = new OAuthProvider(providerInstance, {
...oAuthProviderOptions,
disableRefresh: true,
});
const mockRequest = ({
cookies: {
@@ -277,11 +275,10 @@ describe('OAuthProvider', () => {
});
it('removes refresh cookie when logging out', async () => {
oAuthProviderOptions.disableRefresh = false;
const oauthProvider = new OAuthProvider(
providerInstance,
oAuthProviderOptions,
);
const oauthProvider = new OAuthProvider(providerInstance, {
...oAuthProviderOptions,
disableRefresh: false,
});
const mockRequest = ({
header: () => 'XMLHttpRequest',
@@ -303,10 +300,10 @@ describe('OAuthProvider', () => {
it('gets new access-token when refreshing', async () => {
oAuthProviderOptions.disableRefresh = false;
const oauthProvider = new OAuthProvider(
providerInstance,
oAuthProviderOptions,
);
const oauthProvider = new OAuthProvider(providerInstance, {
...oAuthProviderOptions,
disableRefresh: false,
});
const mockRequest = ({
header: () => 'XMLHttpRequest',
@@ -330,11 +327,10 @@ describe('OAuthProvider', () => {
});
it('handles refresh without capabilities', async () => {
oAuthProviderOptions.disableRefresh = true;
const oauthProvider = new OAuthProvider(
providerInstance,
oAuthProviderOptions,
);
const oauthProvider = new OAuthProvider(providerInstance, {
...oAuthProviderOptions,
disableRefresh: true,
});
const mockRequest = ({
header: () => 'XMLHttpRequest',
plugins/auth-backend/src/providers/github/provider.ts
+1 -1
View File
@@ -75,7 +75,7 @@ export function createGithubProvider(
for (const [env, envConfig] of Object.entries(providerConfig)) {
const config = (envConfig as unknown) as OAuthProviderConfig;
const { secure, appOrigin } = config;
const callbackURLParam = env === 'development' ? '?env=development' : '';
const callbackURLParam = `?env=${env}`;
const opts = {
clientID: config.clientId,
clientSecret: config.clientSecret,
plugins/auth-backend/src/providers/google/provider.ts
+1 -1
View File
@@ -122,7 +122,7 @@ export function createGoogleProvider(
for (const [env, envConfig] of Object.entries(providerConfig)) {
const config = (envConfig as unknown) as OAuthProviderConfig;
const { secure, appOrigin } = config;
const callbackURLParam = env === 'development' ? '?env=development' : '';
const callbackURLParam = `?env=${env}`;
const opts = {
clientID: config.clientId,
clientSecret: config.clientSecret,