paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 21 Packages Projects Releases Wiki Activity

Merge pull request #25910 from kmarkow/fix-techdocs-edit-url-trailing-slash

Browse Source 
Fix TechDocs Edit URL link when trailing slash not present
This commit is contained in:
John Philip
2024-08-06 14:42:19 -04:00
committed by GitHub
parent 2b18c66a4c 18916691d7
commit 2c08403f61
3 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.changeset/tricky-rules-destroy.md
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-techdocs-node': patch
---
Fix TechDocs Edit URL for nested docs
plugins/techdocs-node/src/stages/generate/helpers.test.ts
+1
View File
@@ -115,6 +115,7 @@ describe('helpers', () => {
url | repo_url | edit_uri
${'https://github.com/backstage/backstage'} | ${'https://github.com/backstage/backstage'} | ${undefined}
${'https://github.com/backstage/backstage/tree/main/examples/techdocs/'} | ${'https://github.com/backstage/backstage/tree/main/examples/techdocs/'} | ${'https://github.com/backstage/backstage/edit/main/examples/techdocs/docs'}
${'https://github.com/backstage/backstage/tree/main/examples/techdocs'} | ${'https://github.com/backstage/backstage/tree/main/examples/techdocs'} | ${'https://github.com/backstage/backstage/edit/main/examples/techdocs/docs'}
${'https://github.com/backstage/backstage/tree/main/'} | ${'https://github.com/backstage/backstage/tree/main/'} | ${'https://github.com/backstage/backstage/edit/main/docs'}
${'https://gitlab.com/backstage/backstage'} | ${'https://gitlab.com/backstage/backstage'} | ${undefined}
${'https://gitlab.com/backstage/backstage/-/blob/main/examples/techdocs/'} | ${'https://gitlab.com/backstage/backstage/-/blob/main/examples/techdocs/'} | ${'https://gitlab.com/backstage/backstage/-/edit/main/examples/techdocs/docs'}
plugins/techdocs-node/src/stages/generate/helpers.ts
+1 -1
View File
@@ -117,7 +117,7 @@ export const getRepoUrlFromLocationAnnotation = (
const sourceFolder = integration.resolveUrl({
url: `./${docsFolder}`,
base: target,
base: target.endsWith('/') ? target : `${target}/`,
});
return {
repo_url: target,