fix(catalog/msgraph): read user.select from config

Signed-off-by: LauraMoraB <lmoraballestar@gmail.com>
This commit is contained in:
LauraMoraB
2023-02-06 14:55:39 +01:00
committed by LauraMoraB
parent 1a029e2ff8
commit 28f9883440
3 changed files with 11 additions and 0 deletions
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-catalog-backend-module-msgraph': patch
---
Fixed bug in readProviderConfig as it wasn't reading the user.select field expected from the app-config.yaml configuration
@@ -52,6 +52,7 @@ describe('readMicrosoftGraphConfig', () => {
authority: 'https://login.example.com/',
userExpand: 'manager',
userFilter: 'accountEnabled eq true',
userSelect: ['id', 'displayName', 'department'],
groupExpand: 'member',
groupSelect: ['id', 'displayName', 'description'],
groupFilter: 'securityEnabled eq false',
@@ -69,6 +70,7 @@ describe('readMicrosoftGraphConfig', () => {
authority: 'https://login.example.com/',
userExpand: 'manager',
userFilter: 'accountEnabled eq true',
userSelect: ['id', 'displayName', 'department'],
groupExpand: 'member',
groupSelect: ['id', 'displayName', 'description'],
groupFilter: 'securityEnabled eq false',
@@ -167,6 +169,7 @@ describe('readProviderConfigs', () => {
user: {
expand: 'manager',
filter: 'accountEnabled eq true',
select: ['id', 'displayName', 'department'],
},
group: {
expand: 'member',
@@ -196,6 +199,7 @@ describe('readProviderConfigs', () => {
queryMode: 'advanced',
userExpand: 'manager',
userFilter: 'accountEnabled eq true',
userSelect: ['id', 'displayName', 'department'],
groupExpand: 'member',
groupSelect: ['id', 'displayName', 'description'],
groupFilter: 'securityEnabled eq false',
@@ -264,6 +264,7 @@ export function readProviderConfig(
const userExpand = config.getOptionalString('user.expand');
const userFilter = config.getOptionalString('user.filter');
const userSelect = config.getOptionalStringArray('user.select');
const groupExpand = config.getOptionalString('group.expand');
const groupFilter = config.getOptionalString('group.filter');
@@ -318,6 +319,7 @@ export function readProviderConfig(
tenantId,
userExpand,
userFilter,
userSelect,
groupExpand,
groupFilter,
groupSearch,