addressing review suggestions

Signed-off-by: Brian Fletcher <brian@roadie.io>

.changeset/quick-jars-wait.md

@@ -2,7 +2,7 @@
 '@backstage/plugin-proxy-backend': patch
 ---
 
-If one of the configured proxies is configured badly enough to cause an exception when the middleware is being built it can now be configured to pass the bad proxy by and continue the server startup. Previously the backend would fail to startup.
+Adds a new option `skipInvalidTargets` for the proxy `createRouter` which allows the proxy backend to be started with an invalid proxy configuration. If configured, it will simply skip the failed proxy and mount the other valid proxies.
 
 To configure it to pass by failing proxies:
 
@@ -11,7 +11,7 @@ const router = await createRouter({
   config,
   logger,
   discovery,
-  skipBrokenProxies: true,
+  skipInvalidProxies: true,
 });
 ```
 

plugins/proxy-backend/src/service/router.test.ts

@@ -113,7 +113,7 @@ describe('createRouter', () => {
         config,
         logger,
         discovery,
-        skipBrokenProxies: true,
+        skipInvalidProxies: true,
       });
       expect((logger.warn as jest.Mock).mock.calls[0][0]).toEqual(
         'skipped configuring /test due to Proxy target must be a string',

plugins/proxy-backend/src/service/router.ts

@@ -51,7 +51,7 @@ export interface RouterOptions {
   logger: Logger;
   config: Config;
   discovery: PluginEndpointDiscovery;
-  skipBrokenProxies?: boolean;
+  skipInvalidProxies?: boolean;
 }
 
 export interface ProxyConfig extends Options {
@@ -194,7 +194,7 @@ export async function createRouter(
         buildMiddleware(pathPrefix, options.logger, route, proxyRouteConfig),
       );
     } catch (e) {
-      if (options.skipBrokenProxies) {
+      if (options.skipInvalidProxies) {
         options.logger.warn(`skipped configuring ${route} due to ${e.message}`);
       } else {
         throw e;