Merge pull request #8796 from goenning/go/log-error-tech-insights

[TechInsights] log errors when tech insights throws an error
This commit is contained in:
Fredrik Adelöw
2022-01-13 13:54:23 +01:00
committed by GitHub
2 changed files with 18 additions and 5 deletions
@@ -16,6 +16,7 @@
import {
FactRetriever,
FactRetrieverContext,
TechInsightFact,
TechInsightsStore,
} from '@backstage/plugin-tech-insights-node';
import { FactRetrieverRegistry } from './FactRetrieverRegistry';
@@ -108,16 +109,23 @@ export class FactRetrieverEngine {
this.logger.info(
`Retrieving facts for fact retriever ${factRetriever.id}`,
);
const facts = await factRetriever.handler({
...this.factRetrieverContext,
entityFilter: factRetriever.entityFilter,
});
if (this.logger.isDebugEnabled()) {
let facts: TechInsightFact[] = [];
try {
facts = await factRetriever.handler({
...this.factRetrieverContext,
entityFilter: factRetriever.entityFilter,
});
this.logger.debug(
`Retrieved ${facts.length} facts for fact retriever ${
factRetriever.id
} in ${duration(startTimestamp)}`,
);
} catch (e) {
this.logger.error(
`Failed to retrieve facts for retriever ${factRetriever.id}`,
e,
);
}
try {