Merge pull request #8796 from goenning/go/log-error-tech-insights

[TechInsights] log errors when tech insights throws an error

.changeset/great-points-design.md

@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-tech-insights-backend': patch
+---
+
+Catch errors from a fact retriever and log them.

plugins/tech-insights-backend/src/service/fact/FactRetrieverEngine.ts

@@ -16,6 +16,7 @@
 import {
   FactRetriever,
   FactRetrieverContext,
+  TechInsightFact,
   TechInsightsStore,
 } from '@backstage/plugin-tech-insights-node';
 import { FactRetrieverRegistry } from './FactRetrieverRegistry';
@@ -108,16 +109,23 @@ export class FactRetrieverEngine {
       this.logger.info(
         `Retrieving facts for fact retriever ${factRetriever.id}`,
       );
-      const facts = await factRetriever.handler({
-        ...this.factRetrieverContext,
-        entityFilter: factRetriever.entityFilter,
-      });
-      if (this.logger.isDebugEnabled()) {
+
+      let facts: TechInsightFact[] = [];
+      try {
+        facts = await factRetriever.handler({
+          ...this.factRetrieverContext,
+          entityFilter: factRetriever.entityFilter,
+        });
         this.logger.debug(
           `Retrieved ${facts.length} facts for fact retriever ${
             factRetriever.id
           } in ${duration(startTimestamp)}`,
         );
+      } catch (e) {
+        this.logger.error(
+          `Failed to retrieve facts for retriever ${factRetriever.id}`,
+          e,
+        );
       }
 
       try {