paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 38 Packages Projects Releases Wiki Activity

Merge pull request #768 from spotify/rugvip/noremove

Browse Source 
packages/cli: avoid removing empty lines in remove-plugin
This commit is contained in:
Patrik Oldsberg
2020-05-08 17:05:59 +02:00
committed by GitHub
parent f913777de9 36b0dc849c
commit 24cb7a7f9d
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/commands/remove-plugin/removePlugin.ts
+4 -9
View File
@@ -84,16 +84,11 @@ const removeAllStatementsContainingID = async (file: string, ID: string) => {
const originalContent = await fse.readFile(file, 'utf8');
const contentAfterRemoval = originalContent
.split('\n')
.filter(Boolean) // get rid of empty lines
.filter((statement) => {
return !statement.includes(`${ID}`);
}) // get rid of lines with pluginName
.concat(['']) // newline at end of line
.filter((statement) => !statement.includes(`${ID}`)) // get rid of lines with pluginName
.join('\n');
await fse.writeFile(file, contentAfterRemoval, 'utf8');
const finalContent = await fse.readFile(file, 'utf8');
if (finalContent === originalContent)
throw new Error(`File was not modified.`);
if (originalContent !== contentAfterRemoval) {
await fse.writeFile(file, contentAfterRemoval, 'utf8');
}
};
const capitalize = (str: string): string =>