Clearer filter set, safer hook dependencies.

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-02-25 10:10:42 +01:00
parent 0ca964ee0e
commit 2491754cfc
1 changed files with 5 additions and 2 deletions
@@ -90,14 +90,17 @@ const TechDocsSearchBar = ({

  // Update the filter context when the entityId changes, e.g. when the search
  // bar continues to be rendered, navigating between different TechDocs sites.
+  const { kind, name, namespace } = entityId;
  useEffect(() => {
    setFilters(prevFilters => {
      return {
        ...prevFilters,
-        ...entityId,
+        kind,
+        namespace,
+        name,
      };
    });
-  }, [entityId, setFilters]);
+  }, [kind, namespace, name, setFilters]);

  const handleQuery = (e: ChangeEvent<HTMLInputElement>) => {
    if (!open) {