From 2491754cfc7a17a14393b7b67140b8cdd146331b Mon Sep 17 00:00:00 2001
From: Eric Peterson <ericpeterson@spotify.com>
Date: Fri, 25 Feb 2022 10:10:42 +0100
Subject: [PATCH] Clearer filter set, safer hook dependencies.

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
---
 plugins/techdocs/src/reader/components/TechDocsSearch.tsx | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/plugins/techdocs/src/reader/components/TechDocsSearch.tsx b/plugins/techdocs/src/reader/components/TechDocsSearch.tsx
index e45a26675b..6c0be16f4f 100644
--- a/plugins/techdocs/src/reader/components/TechDocsSearch.tsx
+++ b/plugins/techdocs/src/reader/components/TechDocsSearch.tsx
@@ -90,14 +90,17 @@ const TechDocsSearchBar = ({
 
   // Update the filter context when the entityId changes, e.g. when the search
   // bar continues to be rendered, navigating between different TechDocs sites.
+  const { kind, name, namespace } = entityId;
   useEffect(() => {
     setFilters(prevFilters => {
       return {
         ...prevFilters,
-        ...entityId,
+        kind,
+        namespace,
+        name,
       };
     });
-  }, [entityId, setFilters]);
+  }, [kind, namespace, name, setFilters]);
 
   const handleQuery = (e: ChangeEvent<HTMLInputElement>) => {
     if (!open) {