address review comments

Signed-off-by: Thomas Cooper <57812123+coopernetes@users.noreply.github.com>

.changeset/smooth-rings-mate.md

@@ -2,4 +2,4 @@
 '@backstage/theme': patch
 ---
 
-Fixed a bug to support string fontSize values (`"2.5rem"`) instead of forcing numeric-only values & requiring casts. In addition, added an optional fontFamily prop for h1-h6 BackstageTypography variants to allow further customization.
+Added support for string `fontSize` values (e.g. `"2.5rem"`) in themes in addition to numbers. Also added an optional `fontFamily` prop for header typography variants to allow further customization.

packages/theme/api-report.md

@@ -178,42 +178,7 @@ export function createBaseThemeOptions<PaletteOptions>(
   options: BaseThemeOptionsInput<PaletteOptions>,
 ): {
   palette: PaletteOptions;
-  typography:
-    | BackstageTypography
-    | {
-        htmlFontSize: number;
-        fontFamily: string;
-        h1: {
-          fontSize: number;
-          fontWeight: number;
-          marginBottom: number;
-        };
-        h2: {
-          fontSize: number;
-          fontWeight: number;
-          marginBottom: number;
-        };
-        h3: {
-          fontSize: number;
-          fontWeight: number;
-          marginBottom: number;
-        };
-        h4: {
-          fontWeight: number;
-          fontSize: number;
-          marginBottom: number;
-        };
-        h5: {
-          fontWeight: number;
-          fontSize: number;
-          marginBottom: number;
-        };
-        h6: {
-          fontWeight: number;
-          fontSize: number;
-          marginBottom: number;
-        };
-      };
+  typography: BackstageTypography;
   page: PageTheme;
   getPageTheme: ({ themeId }: PageThemeSelector) => PageTheme;
 };

packages/theme/src/base/createBaseThemeOptions.ts

@@ -57,7 +57,7 @@ export function createBaseThemeOptions<PaletteOptions>(
     throw new Error(`${defaultPageTheme} is not defined in pageTheme.`);
   }
 
-  const defaultTypography = {
+  const defaultTypography: BackstageTypography = {
     htmlFontSize,
     fontFamily,
     h1: {