Resolve code review

Signed-off-by: Dede Hamzah <dehamzah@gmail.com>
This commit is contained in:
Dede Hamzah
2021-12-28 09:25:19 +07:00
parent e762ecb94e
commit 1d10e74080
7 changed files with 11 additions and 16 deletions
+3 -13
View File
@@ -54,12 +54,12 @@ export interface AsyncEntityProviderProps {
refresh?: VoidFunction;
}
// Warning: (ae-forgotten-export) The symbol "BackstageComponentsNameToClassKey" needs to be exported by the entry point index.d.ts
// Warning: (ae-forgotten-export) The symbol "CatalogReactComponentsNameToClassKey" needs to be exported by the entry point index.d.ts
//
// @public (undocumented)
export type BackstageOverrides = Overrides & {
[Name in keyof BackstageComponentsNameToClassKey]?: Partial<
StyleRules<BackstageComponentsNameToClassKey[Name]>
[Name in keyof CatalogReactComponentsNameToClassKey]?: Partial<
StyleRules<CatalogReactComponentsNameToClassKey[Name]>
>;
};
@@ -72,28 +72,18 @@ export { CatalogApi };
// @public (undocumented)
export const catalogApiRef: ApiRef<CatalogApi>;
// Warning: (ae-missing-release-tag) "CatalogReactEntityLifecyclePickerClassKey" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export type CatalogReactEntityLifecyclePickerClassKey = 'input';
// Warning: (ae-missing-release-tag) "CatalogReactEntityOwnerPickerClassKey" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export type CatalogReactEntityOwnerPickerClassKey = 'input';
// Warning: (ae-missing-release-tag) "CatalogReactEntitySearchBarClassKey" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export type CatalogReactEntitySearchBarClassKey = 'searchToolbar' | 'input';
// Warning: (ae-missing-release-tag) "CatalogReactEntityTagPickerClassKey" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export type CatalogReactEntityTagPickerClassKey = 'input';
// Warning: (ae-missing-release-tag) "CatalogReactUserListPickerClassKey" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
export type CatalogReactUserListPickerClassKey =
| 'root'
@@ -31,6 +31,7 @@ import React, { useEffect, useMemo, useState } from 'react';
import { useEntityListProvider } from '../../hooks/useEntityListProvider';
import { EntityLifecycleFilter } from '../../filters';
/** @public */
export type CatalogReactEntityLifecyclePickerClassKey = 'input';
const useStyles = makeStyles(
@@ -33,6 +33,7 @@ import { EntityOwnerFilter } from '../../filters';
import { getEntityRelations } from '../../utils';
import { formatEntityRefTitle } from '../EntityRefLink';
/** @public */
export type CatalogReactEntityOwnerPickerClassKey = 'input';
const useStyles = makeStyles(
@@ -29,6 +29,7 @@ import { useDebounce } from 'react-use';
import { useEntityListProvider } from '../../hooks/useEntityListProvider';
import { EntityTextFilter } from '../../filters';
/** @public */
export type CatalogReactEntitySearchBarClassKey = 'searchToolbar' | 'input';
const useStyles = makeStyles(
@@ -31,6 +31,7 @@ import React, { useEffect, useMemo, useState } from 'react';
import { useEntityListProvider } from '../../hooks/useEntityListProvider';
import { EntityTagFilter } from '../../filters';
/** @public */
export type CatalogReactEntityTagPickerClassKey = 'input';
const useStyles = makeStyles(
@@ -43,6 +43,7 @@ import {
import { UserListFilterKind } from '../../types';
import { reduceEntityFilters } from '../../utils';
/** @public */
export type CatalogReactUserListPickerClassKey =
| 'root'
| 'title'
@@ -24,7 +24,7 @@ import {
CatalogReactEntityOwnerPickerClassKey,
} from './components';
type BackstageComponentsNameToClassKey = {
type CatalogReactComponentsNameToClassKey = {
CatalogReactUserListPicker: CatalogReactUserListPickerClassKey;
CatalogReactEntityLifecyclePicker: CatalogReactEntityLifecyclePickerClassKey;
CatalogReactEntitySearchBar: CatalogReactEntitySearchBarClassKey;
@@ -34,7 +34,7 @@ type BackstageComponentsNameToClassKey = {
/** @public */
export type BackstageOverrides = Overrides & {
[Name in keyof BackstageComponentsNameToClassKey]?: Partial<
StyleRules<BackstageComponentsNameToClassKey[Name]>
[Name in keyof CatalogReactComponentsNameToClassKey]?: Partial<
StyleRules<CatalogReactComponentsNameToClassKey[Name]>
>;
};