feat: use the old way of filtering

Signed-off-by: blam <ben@blam.sh>
This commit is contained in:
blam
2023-05-24 14:29:59 +02:00
parent 26ab53bec2
commit 1b1a04de06
2 changed files with 12 additions and 31 deletions
@@ -22,16 +22,6 @@ import { TemplateCard } from '../TemplateCard';
import { TemplateEntityV1beta3 } from '@backstage/plugin-scaffolder-common';
describe('TemplateGroup', () => {
it('should return a message when no templates are passed in', async () => {
const { getByText } = render(
<TemplateGroup onSelected={jest.fn()} title="Test" templates={[]} />,
);
expect(
getByText(/No templates found that match your filter/),
).toBeInTheDocument();
});
it('should render a card for each template with the template being passed as a prop', () => {
const mockOnSelected = jest.fn();
const mockTemplates: { template: TemplateEntityV1beta3 }[] = [
@@ -130,14 +120,6 @@ describe('TemplateGroup', () => {
);
}
});
it('should render the title when no templates passed', () => {
const { getByText } = render(
<TemplateGroup onSelected={jest.fn()} title="Test" templates={[]} />,
);
expect(getByText('Test')).toBeInTheDocument();
});
it('should render the title when there are templates in the list', () => {
const mockTemplates: { template: TemplateEntityV1beta3 }[] = [
{
@@ -163,10 +145,20 @@ describe('TemplateGroup', () => {
it('should allow for passing through a user given title component', () => {
const TitleComponent = <p>Im a custom header</p>;
const mockTemplates: { template: TemplateEntityV1beta3 }[] = [
{
template: {
apiVersion: 'scaffolder.backstage.io/v1beta3',
kind: 'Template',
metadata: { name: 'test' },
spec: { parameters: [], steps: [], type: 'website' },
},
},
];
const { getByText } = render(
<TemplateGroup
onSelected={jest.fn()}
templates={[]}
templates={mockTemplates}
title={TitleComponent}
/>,
);
@@ -61,18 +61,7 @@ export const TemplateGroup = (props: TemplateGroupProps) => {
typeof title === 'string' ? <ContentHeader title={title} /> : title;
if (templates.length === 0) {
return (
<Content>
{titleComponent}
<Typography variant="body2">
No templates found that match your filter. Learn more about{' '}
<Link to="https://backstage.io/docs/features/software-templates/adding-templates">
adding templates
</Link>
.
</Typography>
</Content>
);
return null;
}
const Card = CardComponent || TemplateCard;