add a migration to catalog-backend to alter target column of locations table to type text

Signed-off-by: Kashish Mittal <kmittal@redhat.com>
This commit is contained in:
Kashish Mittal
2024-10-03 16:10:54 -04:00
parent d3e45d6d6b
commit 120f74bc91
3 changed files with 60 additions and 1 deletions
@@ -36,7 +36,7 @@ exports.up = async function up(knex) {
.comment('Auto-generated ID of the location');
table.string('type').notNullable().comment('The type of location');
table
.text('target')
.string('target')
.notNullable()
.comment('The actual target of the location');
})
@@ -0,0 +1,37 @@
/*
* Copyright 2024 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
// @ts-check
/**
* @param { import("knex").Knex } knex
* @returns { Promise<void> }
*/
exports.up = async function up(knex) {
await knex.schema.alterTable('locations', table => {
table.text('target').alter();
});
};
/**
* @param { import("knex").Knex } knex
* @returns { Promise<void> }
*/
exports.down = async function down(knex) {
await knex.schema.alterTable('locations', table => {
table.string('target').alter();
});
};
@@ -308,4 +308,26 @@ describe('migrations', () => {
await knex.destroy();
},
);
it.each(databases.eachSupportedId())(
'20241003170511_alter_target_in_locations.js, %p',
async databaseId => {
const knex = await databases.init(databaseId);
await migrateUntilBefore(
knex,
'20241003170511_alter_target_in_locations.js',
);
await migrateUpOnce(knex);
const columnInfo = await knex('locations').columnInfo();
expect(columnInfo.target.type).toBe('text');
await migrateDownOnce(knex);
const revertedColumnInfo = await knex('locations').columnInfo();
expect(revertedColumnInfo.target.type).toBe('varchar');
await knex.destroy();
},
);
});