paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 48 Packages Projects Releases Wiki Activity

address feedback

Browse Source 
Signed-off-by: tonedef <kobylk@gmail.com>
This commit is contained in:
tonedef
2022-10-28 13:54:42 -07:00
parent b6ac258061
commit 112c6d5605
3 changed files with 20 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/catalog-backend/migrations/20201005122705_add_entity_full_name.js
+1 -1
View File
@@ -34,7 +34,7 @@ exports.up = async function up(knex) {
// SQLite does not support alter column
if (!knex.client.config.client.includes('sqlite3')) {
await knex.schema.alterTable('entities', table => {
table.string('full_name').notNullable().alter();
table.string('full_name').notNullable().alter({ alterNullable: true });
});
}
plugins/catalog-backend/migrations/20201007201501_index_entity_search.js
+11 -11
View File
@@ -21,17 +21,17 @@
*/
exports.up = async function up(knex) {
await knex.schema.alterTable('entities_search', table => {
if (knex.client.config.client.includes('mysql')) {
table.index(['key'], 'entities_search_key', {
indexType: 'FULLTEXT',
});
table.index(['value'], 'entities_search_value', {
indexType: 'FULLTEXT',
});
} else {
table.index(['key'], 'entities_search_key');
table.index(['value'], 'entities_search_value');
}
const options = knex.client.config.client.includes('mysql') ? { indexType: 'FULLTEXT', } : {}
table.index(
['key'],
'entities_search_key',
options
);
table.index(
['value'],
'entities_search_value',
options
);
});
};
plugins/catalog-backend/migrations/20210302150147_refresh_state.js
+8 -11
View File
@@ -20,11 +20,7 @@
* @param {import('knex').Knex} knex
*/
exports.up = async function up(knex) {
let STRING_TEXT = 'text';
if (knex.client.config.client.includes('mysql')) {
STRING_TEXT = 'string';
}
const isMySQL = knex.client.config.client.includes('mysql');
await knex.schema.createTable('refresh_state', table => {
table.comment('Location refresh states');
table
@@ -94,23 +90,24 @@ exports.up = async function up(knex) {
});
await knex.schema.createTable('refresh_state_references', table => {
const textColumn = isMySQL
? table.string.bind(table)
: table.text.bind(table);
table.comment('Edges between refresh state rows');
table
.increments('id')
.comment('Primary key to distinguish unique lines from each other');
// @ts-ignore
table[STRING_TEXT]('source_key')
textColumn('source_key')
.nullable()
.comment('Opaque identifier for non-entity sources');
// @ts-ignore
table[STRING_TEXT]('source_entity_ref')
textColumn('source_entity_ref')
.nullable()
.references('entity_ref')
.inTable('refresh_state')
.onDelete('CASCADE')
.comment('EntityRef of entity sources');
// @ts-ignore
table[STRING_TEXT]('target_entity_ref')
textColumn('target_entity_ref')
.notNullable()
.references('entity_ref')
.inTable('refresh_state')