Refactored based on feedback

Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>
This commit is contained in:
Andre Wanlin
2022-03-07 10:26:13 -06:00
parent b713a987c8
commit 0f93aeaf8f
2 changed files with 9 additions and 12 deletions
@@ -158,7 +158,7 @@ describe('<CatalogKindHeader />', () => {
<MockEntityListContextProvider
value={{
updateFilters,
queryParameters: { kind: ['templates'] },
queryParameters: { kind: ['template'] },
}}
>
<CatalogKindHeader />
@@ -166,7 +166,7 @@ describe('<CatalogKindHeader />', () => {
</ApiProvider>,
);
expect(updateFilters).toHaveBeenLastCalledWith({
kind: new EntityKindFilter('templates'),
kind: new EntityKindFilter('template'),
});
});
});
@@ -59,20 +59,17 @@ export function CatalogKindHeader(props: CatalogKindHeaderProps) {
.getEntityFacets({ facets: ['kind'] })
.then(response => response.facets.kind?.map(f => f.value).sort() || []);
});
const { updateFilters, queryParameters } = useEntityList();
const {
updateFilters,
queryParameters: { kind: kindParameter },
} = useEntityList();
const queryParamKind = useMemo(
() =>
([queryParameters.kind].flat()[0] ?? initialFilter).toLocaleLowerCase(
'en-US',
),
[initialFilter, queryParameters],
() => [kindParameter].flat()[0],
[kindParameter],
);
const [selectedKind, setSelectedKind] = useState(
([queryParameters.kind].flat()[0] ?? initialFilter).toLocaleLowerCase(
'en-US',
),
queryParamKind ?? initialFilter,
);
useEffect(() => {