paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 30 Packages Projects Releases Wiki Activity

Compute packagePath once in fixIntegrationFor

Browse Source 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
This commit is contained in:
Patrik Oldsberg
2026-01-29 21:22:13 +01:00
parent 5492f10130
commit 0e10859c62
1 changed files with 8 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/cli/src/modules/maintenance/commands/repo/fix.ts
+8 -15
View File
@@ -442,37 +442,30 @@ export function fixIntegrationFor(pkg: FixablePackage) {
return;
}
const packagePath = relativePath(
paths.targetRoot,
resolvePath(pkg.dir, 'package.json'),
);
// Validate that integrationFor is only used on module packages
if (role !== 'backend-plugin-module' && role !== 'frontend-plugin-module') {
const path = relativePath(
paths.targetRoot,
resolvePath(pkg.dir, 'package.json'),
);
throw new Error(
`The 'backstage.integrationFor' field in "${pkg.packageJson.name}" can only be used on module packages (backend-plugin-module or frontend-plugin-module), but package has role '${role}' in "${path}"`,
`The 'backstage.integrationFor' field in "${pkg.packageJson.name}" can only be used on module packages (backend-plugin-module or frontend-plugin-module), but package has role '${role}' in "${packagePath}"`,
);
}
// Validate that integrationFor is an array
if (!Array.isArray(integrationFor)) {
const path = relativePath(
paths.targetRoot,
resolvePath(pkg.dir, 'package.json'),
);
throw new Error(
`Invalid 'backstage.integrationFor' field in "${pkg.packageJson.name}", must be an array of package names in "${path}"`,
`Invalid 'backstage.integrationFor' field in "${pkg.packageJson.name}", must be an array of package names in "${packagePath}"`,
);
}
// Validate that all entries are non-empty strings
for (const entry of integrationFor) {
if (typeof entry !== 'string' || entry.length === 0) {
const path = relativePath(
paths.targetRoot,
resolvePath(pkg.dir, 'package.json'),
);
throw new Error(
`Invalid entry in 'backstage.integrationFor' field in "${pkg.packageJson.name}", all entries must be non-empty package name strings in "${path}"`,
`Invalid entry in 'backstage.integrationFor' field in "${pkg.packageJson.name}", all entries must be non-empty package name strings in "${packagePath}"`,
);
}
}