frontend-app-api: validate route ref IDs

Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Co-authored-by: Philipp Hugenroth <philipph@spotify.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>

packages/frontend-app-api/src/createApp.tsx

@@ -146,6 +146,12 @@ export function extractRouteInfoFromInstanceTree(
     // TODO: join paths in a more robust way
     const fullPath = basePath + routePath;
     if (routeRef) {
+      const routeRefId = (routeRef as any).id; // TODO: properly
+      if (routeRefId !== current.id) {
+        throw new Error(
+          `Route ref '${routeRefId}' must have the same ID as extension '${current.id}'`,
+        );
+      }
       results.set(routeRef, fullPath);
     }