Improvements based on feedback

Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>

plugins/azure-devops-backend/api-report.md

@@ -25,12 +25,31 @@ export class AzureDevOpsApi {
   // (undocumented)
   getAllTeams(): Promise<Team[]>;
   // (undocumented)
+  getBuildDefinitions(
+    projectName: string,
+    definitionName: string,
+  ): Promise<BuildDefinitionReference[]>;
+  // (undocumented)
   getBuildList(
     projectName: string,
     repoId: string,
     top: number,
   ): Promise<Build[]>;
   // (undocumented)
+  getBuildRuns(
+    projectName: string,
+    top: number,
+    repoName?: string,
+    definitionName?: string,
+  ): Promise<BuildRun[]>;
+  // (undocumented)
+  getBuilds(
+    projectName: string,
+    top: number,
+    repoId?: string,
+    definitions?: number[],
+  ): Promise<Build[]>;
+  // (undocumented)
   getDashboardPullRequests(
     projectName: string,
     options: PullRequestOptions,

plugins/azure-devops-backend/src/api/AzureDevOpsApi.ts

@@ -261,6 +261,8 @@ export class AzureDevOpsApi {
     return teamMembers
       .map(teamMember => teamMember.identity?.id)
       .filter((id): id is string => Boolean(id));
+  }
+
   public async getBuildDefinitions(
     projectName: string,
     definitionName: string,
@@ -270,25 +272,7 @@ export class AzureDevOpsApi {
     );
 
     const client = await this.webApi.getBuildApi();
-    return client.getDefinitions(
-      projectName,
-      definitionName,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-      undefined,
-    );
+    return client.getDefinitions(projectName, definitionName);
   }
 
   public async getBuilds(
@@ -346,14 +330,14 @@ export class AzureDevOpsApi {
         projectName,
         definitionName,
       );
-      definitions = buildDefinitions.map(bd => bd.id) as number[];
+      definitions = buildDefinitions
+        .map(bd => bd.id)
+        .filter((bd): bd is number => Boolean(bd));
     }
 
     const builds = await this.getBuilds(projectName, top, repoId, definitions);
 
-    const buildRuns: BuildRun[] = builds.map(build => {
-      return mappedBuildRun(build);
-    });
+    const buildRuns: BuildRun[] = builds.map(mappedBuildRun);
 
     return buildRuns;
   }