Merge pull request #10365 from backstage/blam/bump-knex-in-create-app

Remove `knex` in `@backstage/create-app`

.changeset/fair-dingos-glow.md

@@ -0,0 +1,19 @@
+---
+'@backstage/create-app': patch
+---
+
+Remove the `knex` package that is installed in the `packages/backend` as it's provided by the `@backstage/*` packages for you automatically. You can make the following change in your `packages/backend/package.json` if you wish to apply this change.
+
+```diff
+    "lint": "backstage-cli package lint",
+    "test": "backstage-cli package test",
+    "clean": "backstage-cli package clean",
+-   "migrate:create": "knex migrate:make -x ts"
+```
+
+```diff
+    "express": "^4.17.1",
+    "express-promise-router": "^4.1.0",
+-   "knex": "^0.21.6",
+    "pg": "^8.3.0",
+```

packages/backend/package.json

@@ -23,8 +23,7 @@
     "lint": "backstage-cli package lint",
     "test": "backstage-cli package test",
     "clean": "backstage-cli package clean",
-    "build-image": "docker build ../.. -f Dockerfile --tag example-backend",
-    "migrate:create": "knex migrate:make -x ts"
+    "build-image": "docker build ../.. -f Dockerfile --tag example-backend"
   },
   "dependencies": {
     "@backstage/backend-common": "^0.13.2-next.0",
@@ -69,7 +68,6 @@
     "express": "^4.17.1",
     "express-promise-router": "^4.1.0",
     "express-prom-bundle": "^6.3.6",
-    "knex": "^1.0.2",
     "pg": "^8.3.0",
     "pg-connection-string": "^2.3.0",
     "prom-client": "^14.0.1",

packages/cli/src/lib/role/packageRoles.test.ts

@@ -152,7 +152,6 @@ describe('detectRoleFromPackage', () => {
           lint: 'backstage-cli lint',
           test: 'backstage-cli test',
           clean: 'backstage-cli clean',
-          'migrate:create': 'knex migrate:make -x ts',
         },
       }),
     ).toEqual('backend');

packages/create-app/templates/default-app/packages/backend/package.json.hbs

@@ -13,8 +13,7 @@
     "lint": "backstage-cli package lint",
     "test": "backstage-cli package test",
     "clean": "backstage-cli package clean",
-    "build-image": "docker build ../.. -f Dockerfile --tag backstage",
-    "migrate:create": "knex migrate:make -x ts"
+    "build-image": "docker build ../.. -f Dockerfile --tag backstage"
   },
   "dependencies": {
     "app": "link:../app",
@@ -41,7 +40,6 @@
     "dockerode": "^3.3.1",
     "express": "^4.17.1",
     "express-promise-router": "^4.1.0",
-    "knex": "^0.21.6",
     {{#if dbTypePG}}
     "pg": "^8.3.0",
     {{/if}}