Merge pull request #27308 from backstage/rugvip/tree-fix

cli: fix tree sha reading for repo test

.changeset/grumpy-shoes-return.md

@@ -0,0 +1,5 @@
+---
+'@backstage/cli': patch
+---
+
+Fixed an issue with the `--successCache` flag for `repo test` where the tree hash for the wrong package directory would sometimes be used to generate the cache key.

packages/backend-dynamic-feature-service/src/scanner/plugin-scanner.test.ts

@@ -30,6 +30,7 @@ const mockDir = createMockDirectory();
 
 describe('plugin-scanner', () => {
   const env = process.env;
+
   beforeEach(() => {
     jest.resetModules();
   });
@@ -38,7 +39,6 @@ describe('plugin-scanner', () => {
     mockDir.clear();
     process.env = env;
   });
-
   describe('applyConfig', () => {
     type TestCase = {
       name: string;

packages/cli/src/commands/repo/test.ts

@@ -54,26 +54,36 @@ interface GlobalWithCache extends Global {
  * Use git to get the HEAD tree hashes of each package in the project.
  */
 async function readPackageTreeHashes(graph: PackageGraph) {
-  const pkgs = Array.from(graph.values());
+  const pkgs = Array.from(graph.values()).map(pkg => ({
+    ...pkg,
+    path: relativePath(paths.targetRoot, pkg.dir),
+  }));
   const output = await runPlain(
     'git',
     'ls-tree',
-    '--object-only',
+    '--format="%(objectname)=%(path)"',
     'HEAD',
     '--',
-    ...pkgs.map(pkg => relativePath(paths.targetRoot, pkg.dir)),
+    ...pkgs.map(pkg => pkg.path),
   );
 
-  const treeShaList = output.trim().split(/\r?\n/);
-  if (treeShaList.length !== pkgs.length) {
-    throw new Error(
-      `Error listing project git tree hashes, output length does not equal input length`,
-    );
-  }
-
   const map = new Map(
-    pkgs.map((pkg, i) => [pkg.packageJson.name, treeShaList[i]]),
+    output
+      .trim()
+      .split(/\r?\n/)
+      .map(line => {
+        const [itemSha, ...itemPathParts] = line.split('=');
+        const itemPath = itemPathParts.join('=');
+        const pkg = pkgs.find(p => p.path === itemPath);
+        if (!pkg) {
+          throw new Error(
+            `Unexpectedly missing tree sha entry for path ${itemPath}`,
+          );
+        }
+        return [pkg.packageJson.name, itemSha];
+      }),
   );
+
   return (pkgName: string) => {
     const sha = map.get(pkgName);
     if (!sha) {