Clean up scaffolder config

Signed-off-by: Tim Hansen <timbonicus@gmail.com>

.changeset/cool-rules-smash.md

@@ -0,0 +1,5 @@
+---
+'@backstage/plugin-scaffolder-backend': patch
+---
+
+Removed unused scaffolder visibility configuration; this has been moved to publish actions. Deprecated scaffolder provider configuration keys; these should use the integrations configuration instead.

app-config.yaml

@@ -277,24 +277,6 @@ scaffolder:
   #   email: scaffolder@backstage.io
   # Use to customize the default commit message when new components are created
   # defaultCommitMessage: 'Initial commit'
-  github:
-    token: ${GITHUB_TOKEN}
-    visibility: public # or 'internal' or 'private'
-  gitlab:
-    api:
-      baseUrl: https://gitlab.com
-      token: ${GITLAB_TOKEN}
-    visibility: public # or 'internal' or 'private'
-  azure:
-    baseUrl: https://dev.azure.com/{your-organization}
-    api:
-      token: ${AZURE_TOKEN}
-  bitbucket:
-    api:
-      host: https://bitbucket.org
-      username: ${BITBUCKET_USERNAME}
-      token: ${BITBUCKET_TOKEN}
-    visibility: public # or or 'private'
 
 auth:
   ### Add auth.keyStore.provider to more granularly control how to store JWK data when running

plugins/scaffolder-backend/config.d.ts

@@ -28,30 +28,30 @@ export interface Config {
      * The commit message used when new components are created.
      */
     defaultCommitMessage?: string;
+    /**
+     * @deprecated Replaced by parameters for the publish:github action
+     */
     github?: {
       [key: string]: string;
-      /**
-       * The visibility to set on created repositories.
-       */
-      visibility?: 'public' | 'internal' | 'private';
     };
+    /**
+     * @deprecated Use the Gitlab integration instead
+     */
     gitlab?: {
       api: { [key: string]: string };
-      /**
-       * The visibility to set on created repositories.
-       */
-      visibility?: 'public' | 'internal' | 'private';
     };
+    /**
+     * @deprecated Use the Azure integration instead
+     */
     azure?: {
       baseUrl: string;
       api: { [key: string]: string };
     };
+    /**
+     * @deprecated Use the Bitbucket integration instead
+     */
     bitbucket?: {
       api: { [key: string]: string };
-      /**
-       * The visibility to set on created repositories.
-       */
-      visibility?: 'public' | 'private';
     };
   };
 }