chore: change prop name to memberDisplayTitle

Signed-off-by: djamaile <rdjamaile@gmail.com>
This commit is contained in:
djamaile
2022-01-11 17:25:27 +01:00
parent 3f08dcd696
commit 03016eab49
3 changed files with 10 additions and 8 deletions
+2 -2
View File
@@ -26,7 +26,7 @@ export const EntityGroupProfileCard: ({
// @public (undocumented)
export const EntityMembersListCard: (_props: {
entity?: GroupEntity | undefined;
memberType?: string | undefined;
memberDisplayTitle?: string | undefined;
}) => JSX.Element;
// Warning: (ae-missing-release-tag) "EntityOwnershipCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
@@ -66,7 +66,7 @@ export const GroupProfileCard: ({
// @public (undocumented)
export const MembersListCard: (_props: {
entity?: GroupEntity;
memberType?: string;
memberDisplayTitle?: string;
}) => JSX.Element;
// Warning: (ae-missing-release-tag) "orgPlugin" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
@@ -138,7 +138,7 @@ describe('MemberTab Test', () => {
wrapInTestApp(
<TestApiProvider apis={[[catalogApiRef, catalogApi]]}>
<EntityProvider entity={groupEntity}>
<MembersListCard memberType="Testers" />
<MembersListCard memberDisplayTitle="Testers" />
</EntityProvider>
,
</TestApiProvider>,
@@ -111,10 +111,10 @@ const MemberComponent = ({ member }: { member: UserEntity }) => {
export const MembersListCard = (_props: {
/** @deprecated The entity is now grabbed from context instead */
entity?: GroupEntity;
memberType?: string;
memberDisplayTitle?: string;
}) => {
const { entity: groupEntity } = useEntity<GroupEntity>();
let { memberType } = _props;
let { memberDisplayTitle } = _props;
const {
metadata: { name: groupName, namespace: grpNamespace },
spec: { profile },
@@ -130,7 +130,7 @@ export const MembersListCard = (_props: {
setPage(pageIndex);
};
const pageSize = 50;
memberType = memberType ? memberType : 'Members';
memberDisplayTitle = memberDisplayTitle ? memberDisplayTitle : 'Members';
const {
loading,
@@ -176,7 +176,9 @@ export const MembersListCard = (_props: {
return (
<Grid item>
<InfoCard
title={`${memberType} (${members?.length || 0}${paginationLabel})`}
title={`${memberDisplayTitle} (${
members?.length || 0
}${paginationLabel})`}
subheader={`of ${displayName}`}
{...(nbPages <= 1 ? {} : { actions: pagination })}
>
@@ -190,7 +192,7 @@ export const MembersListCard = (_props: {
) : (
<Box p={2}>
<Typography>
This group has no ${memberType.toLocaleLowerCase()}.
This group has no ${memberDisplayTitle.toLocaleLowerCase()}.
</Typography>
</Box>
)}