From 03016eab49da948ae568a16be811e6b86f53ef4b Mon Sep 17 00:00:00 2001
From: djamaile <rdjamaile@gmail.com>
Date: Tue, 11 Jan 2022 17:25:27 +0100
Subject: [PATCH] chore: change prop name to memberDisplayTitle

Signed-off-by: djamaile <rdjamaile@gmail.com>
---
 plugins/org/api-report.md                            |  4 ++--
 .../Cards/Group/MembersList/MembersListCard.test.tsx |  2 +-
 .../Cards/Group/MembersList/MembersListCard.tsx      | 12 +++++++-----
 3 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/plugins/org/api-report.md b/plugins/org/api-report.md
index 23838c7b9e..c042ae38af 100644
--- a/plugins/org/api-report.md
+++ b/plugins/org/api-report.md
@@ -26,7 +26,7 @@ export const EntityGroupProfileCard: ({
 // @public (undocumented)
 export const EntityMembersListCard: (_props: {
   entity?: GroupEntity | undefined;
-  memberType?: string | undefined;
+  memberDisplayTitle?: string | undefined;
 }) => JSX.Element;
 
 // Warning: (ae-missing-release-tag) "EntityOwnershipCard" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
@@ -66,7 +66,7 @@ export const GroupProfileCard: ({
 // @public (undocumented)
 export const MembersListCard: (_props: {
   entity?: GroupEntity;
-  memberType?: string;
+  memberDisplayTitle?: string;
 }) => JSX.Element;
 
 // Warning: (ae-missing-release-tag) "orgPlugin" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
diff --git a/plugins/org/src/components/Cards/Group/MembersList/MembersListCard.test.tsx b/plugins/org/src/components/Cards/Group/MembersList/MembersListCard.test.tsx
index b4e103c9bd..f1d324a9b1 100644
--- a/plugins/org/src/components/Cards/Group/MembersList/MembersListCard.test.tsx
+++ b/plugins/org/src/components/Cards/Group/MembersList/MembersListCard.test.tsx
@@ -138,7 +138,7 @@ describe('MemberTab Test', () => {
       wrapInTestApp(
         <TestApiProvider apis={[[catalogApiRef, catalogApi]]}>
           <EntityProvider entity={groupEntity}>
-            <MembersListCard memberType="Testers" />
+            <MembersListCard memberDisplayTitle="Testers" />
           </EntityProvider>
           ,
         </TestApiProvider>,
diff --git a/plugins/org/src/components/Cards/Group/MembersList/MembersListCard.tsx b/plugins/org/src/components/Cards/Group/MembersList/MembersListCard.tsx
index 68af803116..ac2e1e0e8f 100644
--- a/plugins/org/src/components/Cards/Group/MembersList/MembersListCard.tsx
+++ b/plugins/org/src/components/Cards/Group/MembersList/MembersListCard.tsx
@@ -111,10 +111,10 @@ const MemberComponent = ({ member }: { member: UserEntity }) => {
 export const MembersListCard = (_props: {
   /** @deprecated The entity is now grabbed from context instead */
   entity?: GroupEntity;
-  memberType?: string;
+  memberDisplayTitle?: string;
 }) => {
   const { entity: groupEntity } = useEntity<GroupEntity>();
-  let { memberType } = _props;
+  let { memberDisplayTitle } = _props;
   const {
     metadata: { name: groupName, namespace: grpNamespace },
     spec: { profile },
@@ -130,7 +130,7 @@ export const MembersListCard = (_props: {
     setPage(pageIndex);
   };
   const pageSize = 50;
-  memberType = memberType ? memberType : 'Members';
+  memberDisplayTitle = memberDisplayTitle ? memberDisplayTitle : 'Members';
 
   const {
     loading,
@@ -176,7 +176,9 @@ export const MembersListCard = (_props: {
   return (
     <Grid item>
       <InfoCard
-        title={`${memberType} (${members?.length || 0}${paginationLabel})`}
+        title={`${memberDisplayTitle} (${
+          members?.length || 0
+        }${paginationLabel})`}
         subheader={`of ${displayName}`}
         {...(nbPages <= 1 ? {} : { actions: pagination })}
       >
@@ -190,7 +192,7 @@ export const MembersListCard = (_props: {
           ) : (
             <Box p={2}>
               <Typography>
-                This group has no ${memberType.toLocaleLowerCase()}.
+                This group has no ${memberDisplayTitle.toLocaleLowerCase()}.
               </Typography>
             </Box>
           )}