Commit Graph

141 Commits

Author SHA1 Message Date
Camila Belo dcba440459 refactor: apply review suggestions
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-07-05 12:02:21 +02:00
Camila Belo 06f9999f4b feat(search-backend-node): check types in error handling
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-06-28 13:47:58 +02:00
Emma Indal 197bca1bc0 Merge branch 'master' into emmai/search-error-handling 2022-06-28 13:01:11 +02:00
Camila Belo 8e63e71b2c feat(search-backend-node): improve error handling
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-06-28 11:59:49 +02:00
github-actions[bot] c92deffe39 Version Packages (next) 2022-06-28 09:27:36 +00:00
Emma Indal 34c97eb35b switch to use .json instead of .send
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-06-22 14:06:09 +02:00
github-actions[bot] 2231987c10 Version Packages (next) 2022-06-21 09:04:17 +00:00
Emma Indal 741b6df63a update api reports
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-06-21 10:02:04 +02:00
Emma Indal 18dad948a1 add custom search error
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-06-20 15:46:35 +02:00
github-actions[bot] 2e2a82c9d7 Version Packages 2022-06-14 09:12:05 +00:00
Eric Peterson c7ce7b1eb0 Test rank handling in all search engines.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-06-10 15:36:11 +02:00
Eric Peterson 915700f64f Set a pagination-aware rank value for all search engines.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-06-10 15:36:11 +02:00
github-actions[bot] b844443164 Version Packages (next) 2022-06-03 15:01:16 +00:00
Emma Indal 2e6b24d537 clean up api report for search-backend-node package
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-06-02 12:02:00 +02:00
github-actions[bot] a13ab262de Version Packages (next) 2022-05-31 11:51:41 +00:00
Eric Peterson 3bb25a9acc Initial implementation of a generic ndjson collator.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-05-30 19:30:56 +02:00
github-actions[bot] bcc563abe9 Version Packages (next) 2022-05-24 11:05:52 +00:00
Camila Belo 3345dbf84b Merge pull request #11523 from cowboyd/propagate-index-failure
Don't swallow indexing failures
2022-05-18 16:00:38 +02:00
github-actions[bot] 64a03bd946 Version Packages 2022-05-17 09:26:29 +00:00
Charles Lowell bde1631c83 Don't swallow indexing failures
When an error occurs in the indexer pipeline, it logs it out, and then
drops it on the floor. This is problematic because externally, from
the task scheduler's perspective, it appears to have succeeded, which
is not true.

As a result, these failures are invisible to tooling which introspects
over tasks.

This makes the index task promise resolve when the pipeline finishes as
before, but it rejects if the pipeline failed.

Signed-off-by: Charles Lowell <cowboyd@frontside.com>
2022-05-16 15:48:37 +03:00
github-actions[bot] c02ce52da1 Version Packages (next) 2022-05-10 08:00:04 +00:00
Fredrik Adelöw 16dcf2a807 Merge pull request #10981 from kuangp/feat/search/highlight
feat(search): highlight search result terms
2022-05-09 18:27:07 +02:00
Phil Kuang 3a74e203a8 feat(search): highlight search result terms
Signed-off-by: Phil Kuang <pkuang@factset.com>
2022-05-09 11:13:34 -04:00
Eric Peterson 71d3432710 Set the default batchSize to 1000 for all search engines.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-05-01 16:19:58 +02:00
github-actions[bot] 1bff70d602 Version Packages (next) 2022-04-26 12:22:43 +00:00
github-actions[bot] 3f7acfb96e Version Packages 2022-04-19 14:28:08 +00:00
github-actions[bot] 2e1cce5528 Version Packages (next) 2022-04-12 15:19:00 +00:00
Phil Kuang 0a63e99a26 feat(search): handle search indexing coordination among nodes
Signed-off-by: Phil Kuang <pkuang@factset.com>
2022-04-06 14:03:04 -04:00
Eric Peterson 1cd678be2b Fix tsc errors in search-backend-node
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-04-04 16:01:13 +02:00
github-actions[bot] e6f3fb8575 Version Packages (next) 2022-03-29 08:42:22 +00:00
Patrik Oldsberg 850e0ebbe3 search-backend-node: update runPeriodically test to work with jest 27
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-03-25 11:28:14 +01:00
github-actions[bot] ad955c1b1b Version Packages (next) 2022-03-22 12:28:03 +00:00
Mike Lewis d07ed471dc search-backend-node: use new IndexableResultSet type as return type of engine#query
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2022-03-17 12:39:42 +00:00
github-actions[bot] 0bc1611d6e Version Packages 2022-03-17 09:02:30 +00:00
Dimitris Apostolou aedd4daa66 Fix typos
Signed-off-by: Dimitris Apostolou <dimitris.apostolou@icloud.com>
2022-03-13 14:12:05 +02:00
github-actions[bot] b6d947b67f Version Packages 2022-03-10 11:30:23 +00:00
github-actions[bot] 1693f2dc74 Version Packages (next) 2022-03-09 16:09:04 +00:00
Patrik Oldsberg 1f87e8a376 Merge pull request #10037 from backstage/rugvip/role-lint
cli: introduce role-based lint configuration setup
2022-03-08 09:27:19 +01:00
Patrik Oldsberg 09b37063f2 packages,plugins: migrate to new lint config
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-03-07 14:53:43 +01:00
blam 571319d4e2 chore: finishg off some other api-report fixing
Signed-off-by: blam <ben@blam.sh>
2022-03-07 10:15:55 +00:00
Eric Peterson 3e54f6c436 Use @backstage/plugin-search-common instead of @backstage/search-common
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-03-04 18:47:55 +01:00
github-actions[bot] 3c8bb2854d Version Packages 2022-03-03 15:23:53 +00:00
Eric Peterson 0547246b84 Clean up search-common/search-backend-node APIs, indicating beta.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-03-02 17:29:18 +01:00
Eric Peterson a151cf2a88 Finalize exports for search-backend-node module
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-03-02 17:26:58 +01:00
Eric Peterson c87be57d3a Update LunrSearchEngine to be stream-based
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-03-02 17:26:57 +01:00
Eric Peterson cef19ee966 Introduce a base classes to simplify stream-based implementations
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-03-02 17:26:57 +01:00
Eric Peterson ce3f566e9c Introduce test utilities for stream-based search implementations
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-03-02 17:26:57 +01:00
Eric Peterson 2eae26293e Update IndexBuilder to be a stream pipeline
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-03-02 17:26:57 +01:00
Eric Peterson 804c7906cf Update core search types to be stream-based
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-03-02 17:26:56 +01:00
github-actions[bot] c9da151d84 Version Packages 2022-02-24 13:54:37 +00:00