Commit Graph

61 Commits

Author SHA1 Message Date
Patrik Oldsberg 9c01007cb0 Merge pull request #23205 from backstage/rugvip/bep3-auth
beps/0003: new cookie auth design
2024-02-27 09:11:22 +01:00
Patrik Oldsberg 2e37491808 Update beps/0003-auth-architecture-evolution/README.md
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-27 01:44:23 +01:00
Patrik Oldsberg d587052786 Merge pull request #23045 from backstage/freben/graphs
bep-0003: illustrate with some sequence diagrams
2024-02-26 15:56:56 +01:00
Patrik Oldsberg 05a4bbb5d0 beps/0003: add none credential and expiration times
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-26 10:17:50 +01:00
Patrik Oldsberg 432fe068fe beps/0003: bring back high-level cookie helpers
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-23 15:52:08 +01:00
Patrik Oldsberg 6c4e1c43b6 beps/0003: new cookie auth design
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-23 14:27:22 +01:00
Patrik Oldsberg eaabaaec81 Merge pull request #22970 from mareklibra/messagingInsteadOfWorkflows
chore(notifications): narrow the scope to messaging
2024-02-22 11:30:07 +01:00
Marek Libra ffa828b7f2 chore(notifications): narrow the scope to messaging
Signed-off-by: Marek Libra <marek.libra@gmail.com>
2024-02-20 16:10:06 +01:00
bnechyporenko 3a1feaff25 wip
Signed-off-by: bnechyporenko <bnechyporenko@bol.com>
2024-02-19 19:41:40 +01:00
Fredrik Adelöw 3b5d4f6c16 bep-0003: illustrate with some sequence diagrams
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2024-02-19 14:01:31 +01:00
bnechyporenko 9aa01eeb08 Updated BEP 0004
Signed-off-by: bnechyporenko <bnechyporenko@bol.com>
2024-02-18 12:42:04 +01:00
Patrik Oldsberg cf59dc40b9 Update beps/0003-auth-architecture-evolution/README.md
Co-authored-by: Phil Kuang <pkuang@factset.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-15 17:17:16 +01:00
Patrik Oldsberg 468f51100c Update beps/0003-auth-architecture-evolution/README.md
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-15 16:03:09 +01:00
Patrik Oldsberg 43b4e3500f beps/0003: service and rollout updates + move to implementable
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Carl-Erik Bergström <cbergstrom@spotify.com>
Co-authored-by: blam <ben@blam.sh>
Co-authored-by: Camila Belo <camilaibs@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-15 14:35:32 +01:00
bnechyporenko ea20680441 wip
Signed-off-by: bnechyporenko <bnechyporenko@bol.com>
2024-02-14 15:06:30 +01:00
bnechyporenko 835c5ef069 Accepted the suggestion to update the list of authors
Signed-off-by: bnechyporenko <bnechyporenko@bol.com>
2024-02-14 15:06:30 +01:00
bnechyporenko 1e346dca7a wip
Signed-off-by: bnechyporenko <bnechyporenko@bol.com>
2024-02-14 15:06:30 +01:00
bnechyporenko 7c07dafc15 wip
Signed-off-by: bnechyporenko <bnechyporenko@bol.com>
2024-02-14 15:06:30 +01:00
bnechyporenko b81383bcf1 BEP: Scaffolder task idempotency
Signed-off-by: bnechyporenko <bnechyporenko@bol.com>
2024-02-14 15:06:30 +01:00
Patrik Oldsberg 0376d88510 Merge pull request #22866 from backstage/rugvip/bep3-updates
beps/0003: refactor to use principals + add config
2024-02-13 14:29:15 +01:00
Patrik Oldsberg 9414cf2549 Merge pull request #22784 from drodil/notifications_bep3
beps: add more todos and future considerations to bep
2024-02-13 13:38:04 +01:00
Patrik Oldsberg 7b6e215ecb Update beps/0003-auth-architecture-evolution/README.md
Co-authored-by: Phil Kuang <pkuang@factset.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-11 19:55:59 +01:00
Patrik Oldsberg f8cc08ac4c beps/0003: refactor to use principals + add config
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-11 16:47:13 +01:00
Patrik Oldsberg a4b7bc4a6b beps/0003: update discussion issue link
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-09 15:25:18 +01:00
Patrik Oldsberg 40a1b52f58 beps/0003: updates to align with experimental design
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-08 18:13:12 +01:00
Heikki Hellgren 9b57a487c2 beps: add more todos and future considerations to bep
these are also as task list in the #22213 but adding them here as well
for bookkeeping + some new ideas that should be considered

Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
2024-02-08 11:07:53 +02:00
Patrik Oldsberg a029c41837 beps/0003: add TODOs for issuing service tokens
Couple of concerns around how service tokens are issued that came up. First one is whether we should require callers to specify which plugin they want to talk to - as this information can be quite valuable to the implementation. Second is how we make it hard to forget to forward credentials, since the existing interface doesn't really do that.

Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-07 15:14:38 +01:00
Patrik Oldsberg 53df2b0223 beps/0003: updated identity management + add reasoning around access control patterns
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Carl-Erik Bergström <cbergstrom@spotify.com>
Co-authored-by: blam <ben@blam.sh>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-06 21:41:44 +01:00
Patrik Oldsberg fe2e15d458 Merge pull request #22661 from drodil/bep_remove_image
beps: remove image from the notification payload
2024-02-02 17:02:55 +01:00
Patrik Oldsberg 0e0fc02ba4 Merge pull request #22634 from backstage/rugvip/auth-bep
beps/0003: updated implementation proposal, removing httpAuth.middleware
2024-02-02 16:07:24 +01:00
Heikki Hellgren c8a5f640df beps: remove image from the notification payload
relates to #22213 and #22641

Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
2024-02-02 15:38:41 +02:00
Heikki Hellgren bc6641d87d beps: restore topic to the document
Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
2024-02-02 14:50:07 +02:00
Heikki Hellgren 3af10366c3 beps: fix review comments
Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
2024-02-02 12:18:51 +02:00
Heikki Hellgren 85709f15de beps: add information that was agreed on the meeting
Signed-off-by: Heikki Hellgren <heikki.hellgren@op.fi>
2024-02-02 12:05:17 +02:00
Patrik Oldsberg 7ff2e4257f Merge pull request #22510 from mareklibra/bep.notifications.content
chore: specify content of a notification
2024-02-02 10:49:17 +01:00
Patrik Oldsberg c4473a314b Apply suggestions from code review
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-02-01 18:13:37 +01:00
Patrik Oldsberg 6a5702f087 Merge pull request #22629 from backstage/rugvip/df-goals
beps/0002: refine summary/motivation/goals
2024-02-01 08:51:22 +01:00
Patrik Oldsberg e2101e8892 beps/0003: updated implementation proposal, removing httpAuth.middleware
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-01-31 18:02:48 +01:00
Patrik Oldsberg aa53f7add4 Merge pull request #22609 from backstage/rugvip/opt-out
beps/0003: add goal to make sure auth is opt-out
2024-01-31 15:56:23 +01:00
Patrik Oldsberg 011147d9fd Merge pull request #22608 from backstage/rugvip/usage-patterns
beps/0003: add a few usage patterns for HttpAuthService
2024-01-31 15:56:16 +01:00
Patrik Oldsberg 33c0d74c0c Merge pull request #22513 from Hyperkid123/bep-0002-dynamic-frontends-sharing
bep: 0002 module federation dependency sharing testing
2024-01-31 13:50:21 +01:00
Patrik Oldsberg e04887887c beps/0002: refine summary/motivation/goals
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-01-31 13:38:45 +01:00
Martin Marosi 4d3cbf7877 bep: 0002 module federation dependency sharing testing
Signed-off-by: Martin Marosi <marvusm.mmi@gmail.com>
2024-01-31 12:09:04 +01:00
Patrik Oldsberg 736173af2d Update beps/0003-auth-architecture-evolution/README.md
Co-authored-by: Ben Lambert <blam@spotify.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-01-30 18:03:36 +01:00
Patrik Oldsberg 6a575f9fb4 beps/0003: add goal to make sure auth is opt-out
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-01-30 18:00:55 +01:00
Patrik Oldsberg 3448af6e17 beps/0003: add a few usage patterns for HttpAuthService
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-01-30 17:04:51 +01:00
Patrik Oldsberg daa64dcfab beps/0003: add goal to implement some obo flow
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-01-30 13:50:15 +01:00
Patrik Oldsberg d8f73229d6 Apply suggestions from code review
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-01-30 13:48:44 +01:00
Patrik Oldsberg f72b0325cb beps: add Auth Architecture Evolution
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2024-01-30 12:16:31 +01:00
Marek Libra 62ba08930f chore: specify content of a notification
Signed-off-by: Marek Libra <marek.libra@gmail.com>
2024-01-26 09:45:57 +01:00