Commit Graph

207 Commits

Author SHA1 Message Date
Eric Peterson 5388e6bdc5 Properly name versioned search modal context.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-06-03 13:35:13 +02:00
Camila Belo 87f17276f5 fix(search): use parent if its state is defined
Co-authored-by: Anders Näsman <andersn@spotify.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-05-17 10:16:58 +02:00
Eric Peterson bef56488ad Introduce SearchModalProvider to allow modal to be controlled externally
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-05-16 15:20:18 +02:00
Phil Kuang 3a74e203a8 feat(search): highlight search result terms
Signed-off-by: Phil Kuang <pkuang@factset.com>
2022-05-09 11:13:34 -04:00
Emma Indal b9291e1b83 replace usage of api provider and test api registry with TestApiProvider
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-29 11:53:40 +02:00
Emma Indal d47ae8f6f7 replace all usages of SearchContextProviderForStorybook
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-29 11:21:30 +02:00
Phil Kuang 11a46863de fix(HomePageSearchBar): don't require SearchContext
Signed-off-by: Phil Kuang <pkuang@factset.com>
2022-04-22 08:22:43 -04:00
Emma Indal 215fcb0728 test fixups
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-14 16:00:59 +02:00
Emma Indal 5f8b0909f7 import from '@backstage/plugin-search-react'
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-14 16:00:40 +02:00
Emma Indal 0cba692d97 delete deprecated search context
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-14 15:59:14 +02:00
Emma Indal b079651045 Merge branch 'master' into feat/customSearchModal 2022-04-12 13:07:13 +02:00
Emma Indal b7d035cc29 feedback fixups
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-11 17:11:52 +02:00
Emma Indal 301b4606e3 import from new search-react package
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-11 11:42:57 +02:00
Emma Indal 09cba0bdae deprecate search api ref, search api interface and search context in plugin-search
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-04-11 11:41:59 +02:00
Phil Kuang 5c062f275e feat(SidebarSearchModal): support customizing content
Signed-off-by: Phil Kuang <pkuang@factset.com>
2022-04-06 16:02:45 -04:00
Johan Haals c9201ca186 chore: remove rendudant expect
Signed-off-by: Johan Haals <johan.haals@gmail.com>
2022-04-05 10:27:32 +02:00
Eric Peterson 6303fe61e3 Fix SearchBar fake timer tests for latest user-event.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
Signed-off-by: Johan Haals <johan.haals@gmail.com>
2022-04-05 10:19:54 +02:00
Johan Haals fbee9f49e5 chore: await tests
Signed-off-by: Johan Haals <johan.haals@gmail.com>
2022-04-05 10:19:54 +02:00
Johan Haals b1190bf676 await userEvent
Signed-off-by: Johan Haals <johan.haals@gmail.com>
2022-04-05 10:19:54 +02:00
Mike Lewis 38e01f2f70 search: switch to SearchDocument type in DefaultResultListItem props
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2022-03-17 12:39:42 +00:00
Dimitris Apostolou aedd4daa66 Fix typos
Signed-off-by: Dimitris Apostolou <dimitris.apostolou@icloud.com>
2022-03-13 14:12:05 +02:00
Eric Peterson 3e54f6c436 Use @backstage/plugin-search-common instead of @backstage/search-common
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-03-04 18:47:55 +01:00
Johan Haals 7aeb491394 catalog-model: deprecate ENTITY_DEFAULT_NAMESPACE, replace with DEFAULT_NAMESPACE
Signed-off-by: Johan Haals <johan.haals@gmail.com>
2022-02-15 10:27:57 +01:00
Vincenzo Scamporlino 99d8205a8d useSearchModal: clarify tests
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-02-10 14:40:55 +01:00
Vincenzo Scamporlino 52d2d36b4b Move SearchModal state to useSearchModal
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-02-10 07:19:09 +01:00
Vincenzo Scamporlino f903743142 Improve SearchContext api report
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-02-09 18:06:50 +01:00
Vincenzo Scamporlino eb1386e284 Split storybook SearchContextProvider
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-02-09 18:06:50 +01:00
Vincenzo Scamporlino 28e9487f48 Remove open state from SearchContext
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-02-09 18:06:48 +01:00
Vincenzo Scamporlino 4a4ab7c603 Invoke search only when SearchModal is visible
Signed-off-by: Vincenzo Scamporlino <me@vinzscam.dev>
2022-02-04 16:22:10 +01:00
Jussi Hallila faf49ba82f Add line clamping to search results on modal search screen. (#9331)
* Add line clamping to search results on modal search screen.

Signed-off-by: Jussi Hallila <jussi@hallila.com>

* Add mock to test so we don't have to spin up canvas with jsdom.

Signed-off-by: Jussi Hallila <jussi@hallila.com>
2022-02-04 13:02:22 +01:00
Otto Sichert 6efb76581c Use fake timers to test search filter hooks debounce
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-01-25 15:40:14 +01:00
Eric Peterson 8f370b038d Review feedback.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-01-24 13:11:51 +01:00
Eric Peterson 1dbe63ec39 Don't fallback to name on label to help clarify the different uses for each and allow label-less filters.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-01-24 13:06:39 +01:00
Eric Peterson 21705f6432 Document asyncValues/asyncDebounce props.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-01-24 13:06:39 +01:00
Eric Peterson 3b0000669a Test filter utility hooks.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-01-24 13:06:39 +01:00
Eric Peterson 73811cfb33 Refactor default value logic into utility hook.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-01-24 13:06:39 +01:00
Eric Peterson c84c404fc8 Initial tests.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-01-24 13:06:39 +01:00
Eric Peterson 84208528d9 Use precise imports for react-use hooks.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-01-24 13:06:39 +01:00
Eric Peterson bb20c30a7d Add initial <Search.Autocomplete /> implementation.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-01-24 13:06:39 +01:00
Eric Peterson d4d48e1b1a Add asyncValues and asyncDebounce to props and implement in select filter.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-01-24 13:06:39 +01:00
Eric Peterson edfb46bc71 Add an internal utility hook for handling async values.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-01-24 13:06:39 +01:00
Emma Indal 2f0d3d3278 [Home] forward classes to HomePageSearchBar instead of using className (#9049)
* override styles

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* add changeset

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* update api report

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* forward classes instad of using className

Signed-off-by: Emma Indal <emma.indahl@gmail.com>

* update changeset breaking change, add instructions

Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-01-21 12:24:23 +01:00
Fredrik Adelöw 5754f2d200 Merge pull request #8455 from Sarabadu/master
[RFC] LayoutProvider and focusContent
2022-01-19 09:32:16 +01:00
Juan Pablo Garcia Ripa 14b882a696 Move layout context to SidabarPage
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
2022-01-14 18:05:55 +01:00
Juan Pablo Garcia Ripa 5bd03f03be fix conflict resolution
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
2022-01-14 18:04:19 +01:00
Juan Pablo Garcia Ripa eae85fecac add focus after search
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>

add provider to report

Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
2022-01-14 18:04:11 +01:00
Juan Pablo Garcia Ripa 8bb0f4bc8a add LayoutProvider
Signed-off-by: Juan Pablo Garcia Ripa <sarabadu@gmail.com>
2022-01-14 17:57:45 +01:00
Patrik Oldsberg 5535336292 search: update api tests to mock getCredentials
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-01-13 19:51:31 +01:00
Patrik Oldsberg 51fbedc445 plugins: migrate usage of deprecated IdentityApi methods
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-01-13 19:51:30 +01:00
Eric Peterson 22a9001e69 Mock API, not module.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-01-13 09:42:11 +01:00