Spinners cause unnecessary UX distraction.
Case 1 (when docs are built and are to be served): Spinners appear for a split second before the name of site shows up. This unnecessarily distracts eyes because spinners increase the size of the Header. A dot (.) would do fine. Definitely more can be done.
Case 2 (when docs are being generated): There is already a linear progress bar (which is recommended in Storybook). Spinners are not good. 🤷
1. Don't use mkdocs in name of APIs or variables. It is an implementation detail and liable to change in future.
2. techDocsApi.getMetadata('mkdocs') and techDocsAPI.getMetadata('entity') should be two separate functions just because their responses differ in structure. They should also be type checked.
3. Use either 'techdocs' or 'TechDocs' consistently. 'techDocs' seems like an unnecessary third way to write TechDocs, which can be avoided.
4. Remove unused /plugins/techdocs-backend/src/service/metadata.ts file
* TechDocs: Logger already prints the name of plugin
* TechDocs: Display a custom error message if provided
* TechDocs: throw custom error message if index.md is not present
* Language improvements. Thanks @freben
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
* 'master' of github.com:spotify/backstage:
Read git auth token from backend config (#2992)
chore(catalog-model): add the petstore into the default entities
chore(deps-dev): bump @storybook/addon-actions from 6.0.21 to 6.0.26
chore(deps): bump eslint-config-prettier from 6.10.0 to 6.14.0
Add API docs link to About card
adds a sample organization set of users and groups (#2963)
Make sure hasCostsWithinTimeframe is a boolean
fix(catalog-backend): fix codeowners processor to handle users
feat(catalog): add simple client side paging
default to last 30 days
Removed default-branch library since it's no longer used (#3019)
useRealTimers in onCssReady test case
move type dependecy
remove unused import
changeset
simpler query params
* 'master' of github.com:spotify/backstage: (139 commits)
Cleanup
Update PinButton.test.tsx
feat: update github insights plugin version (#2973)
Ignore IntelliJ *.iml files (#2971)
chore(deps): bump rollup-plugin-dts from 1.4.11 to 1.4.13
fix the plugin card on plugins page
align 'Add to Marketplace' button on plugins page
fix the PluginGrid on mobiles sizes
use getBy query instead of queryBy when asserting for elements present in document (#2951)
Update PinButton.tsx
Add test case for Progress component (#2953)
fix the styling of footer copy on mobile
add changeset
handle the case where no entities are available to show
core-api: work around issue with ApiRef export const declarations
core-api: move utility api system implementation into apis/system
Update docs regarding npm config ignore-scripts flag
Another try
Fix Core Features configuration id (#2948)
Fix test?
...
* remove data-testid from div
* add test case for Progress component
* add changeset
* update the GraphiQLPage test cases to handle Progress timeout
* update the RadarComponent and RadarPage test case to handle Progress timeout
* update the TechDocsProgressBar test case to handle Progress timeout
* add changeset
keshan