paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 37 Packages Projects Releases Wiki Activity
26,886 Commits 1 Branch 0 Tags
e2237ddaadad2c377e6966709acd4ecdc9475e52
Commit Graph

67 Commits

Author SHA1 Message Date
Camila Belo 3345dbf84b Merge pull request #11523 from cowboyd/propagate-index-failure 
Don't swallow indexing failures
 2022-05-18 16:00:38 +02:00
Charles Lowell bde1631c83 Don't swallow indexing failures 
When an error occurs in the indexer pipeline, it logs it out, and then
drops it on the floor. This is problematic because externally, from
the task scheduler's perspective, it appears to have succeeded, which
is not true.

As a result, these failures are invisible to tooling which introspects
over tasks.

This makes the index task promise resolve when the pipeline finishes as
before, but it rejects if the pipeline failed.

Signed-off-by: Charles Lowell <cowboyd@frontside.com>
 2022-05-16 15:48:37 +03:00
Fredrik Adelöw 16dcf2a807 Merge pull request #10981 from kuangp/feat/search/highlight 
feat(search): highlight search result terms
 2022-05-09 18:27:07 +02:00
Phil Kuang 3a74e203a8 feat(search): highlight search result terms 
Signed-off-by: Phil Kuang <pkuang@factset.com>
 2022-05-09 11:13:34 -04:00
Eric Peterson 71d3432710 Set the default batchSize to 1000 for all search engines. 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2022-05-01 16:19:58 +02:00
Phil Kuang 0a63e99a26 feat(search): handle search indexing coordination among nodes 
Signed-off-by: Phil Kuang <pkuang@factset.com>
 2022-04-06 14:03:04 -04:00
Eric Peterson 1cd678be2b Fix tsc errors in search-backend-node 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2022-04-04 16:01:13 +02:00
Patrik Oldsberg 850e0ebbe3 search-backend-node: update runPeriodically test to work with jest 27 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-03-25 11:28:14 +01:00
Mike Lewis d07ed471dc search-backend-node: use new IndexableResultSet type as return type of engine#query 
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
 2022-03-17 12:39:42 +00:00
Dimitris Apostolou aedd4daa66 Fix typos 
Signed-off-by: Dimitris Apostolou <dimitris.apostolou@icloud.com>
 2022-03-13 14:12:05 +02:00
Eric Peterson 3e54f6c436 Use @backstage/plugin-search-common instead of @backstage/search-common 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2022-03-04 18:47:55 +01:00
Eric Peterson 0547246b84 Clean up search-common/search-backend-node APIs, indicating beta. 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2022-03-02 17:29:18 +01:00
Eric Peterson a151cf2a88 Finalize exports for search-backend-node module 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2022-03-02 17:26:58 +01:00
Eric Peterson c87be57d3a Update LunrSearchEngine to be stream-based 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2022-03-02 17:26:57 +01:00
Eric Peterson cef19ee966 Introduce a base classes to simplify stream-based implementations 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2022-03-02 17:26:57 +01:00
Eric Peterson ce3f566e9c Introduce test utilities for stream-based search implementations 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2022-03-02 17:26:57 +01:00
Eric Peterson 2eae26293e Update IndexBuilder to be a stream pipeline 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2022-03-02 17:26:57 +01:00
Eric Peterson 804c7906cf Update core search types to be stream-based 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2022-03-02 17:26:56 +01:00
MT Lewis 634abc1a41 search: move DocumentTypeInfo to search-common 
Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
 2022-01-25 13:01:40 +00:00
MT Lewis f6389e9e5d search-backend-node: track document visibility permission by type in IndexBuilder 
Tracking permissions by collator ensures that all the documents of a
given type are authorized using the same permission. This is not
critical for result-by-result authorization, but will likely be a
useful constraint when adding in-engine permission filtering to
specific search engines in the future.

Signed-off-by: MT Lewis <mtlewis@users.noreply.github.com>
 2022-01-25 13:01:38 +00:00
Fredrik Adelöw 5333451def Got rid of the last brace-typed and hyphen-less params etc 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
 2022-01-10 09:48:12 +01:00
Tomasz Szuba 428061d7e5 Add tests 
Signed-off-by: Tomasz Szuba <tszuba@box.com>
 2021-10-21 14:04:58 +02:00
Tomasz Szuba 0de67c4d2a Handle single-item array filter in Lunr search engine 
Signed-off-by: Tomasz Szuba <tszuba@box.com>
 2021-10-21 13:54:44 +02:00
Patrik Oldsberg 8142a8ecb2 packages,plugins: add package documentation 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2021-09-14 18:47:53 +02:00
Oliver Sand 532b4cc656 Rework search paging based on cursors 
Signed-off-by: Oliver Sand <oliver.sand@sda-se.com>
 2021-09-02 10:22:41 +02:00
Oliver Sand 3abef1177e Implement offset and limit based paging in Lunr search engine 
Signed-off-by: Oliver Sand <oliver.sand@sda-se.com>
 2021-09-02 10:19:32 +02:00
Jussi Hallila d9c13d535b Implement ElasticSearch search engine 
* Adding indexing, searching and default translator for ElasticSearch engine
* Modifying default backend to use ES if it is enabled
* Adding configuration schema to configure ElasticSearch 3 different ways
   * Elastic.co hosted solution
   * AWS hosted ElasticSearch Service
   * Custom, using standard ElasticSearch URL and auth info
* Add and modify some of the documentation regarding search

Signed-off-by: Jussi Hallila <jussi@hallila.com>
 2021-07-30 14:26:32 +02:00
Oliver Sand 97b2eb37b2 Change return value of SearchEngine.index to Promise<void> 
Signed-off-by: Oliver Sand <oliver.sand@sda-se.com>
 2021-07-09 11:26:42 +02:00
Oliver Sand d4507650bd Merge pull request #6381 from SDA-SE/feat/better-lunr-results 
Build search queries using the query build in `LunrSearchEngine`
 2021-07-08 11:43:28 +02:00
Oliver Sand 9f3ecb555a Build search queries using the query build in LunrSearchEngine 
Signed-off-by: Oliver Sand <oliver.sand@sda-se.com>
 2021-07-07 19:41:54 +02:00
Oliver Sand 0466606d84 Add test for runPeriodically 
Signed-off-by: Oliver Sand <oliver.sand@sda-se.com>
 2021-07-06 18:58:06 +02:00
Oliver Sand 03715ceaa4 Add comment and remove initial run 
Signed-off-by: Oliver Sand <oliver.sand@sda-se.com>
 2021-07-06 16:37:38 +02:00
Oliver Sand 4176a60e50 Make sure that the search scheduler doesn't run to many tasks in parallel 
Signed-off-by: Oliver Sand <oliver.sand@sda-se.com>
 2021-07-06 15:19:59 +02:00
Eric Peterson c086a1cd92 Merge pull request #6134 from SDA-SE/feat/default-catalog-collator-error 
Handle errors in collators and decorators and log them
 2021-06-22 16:22:14 +02:00
Jesse Bye 3ec487502e Add test case; update changeset message 
Signed-off-by: Jesse Bye <jbye@riskalyze.com>
 2021-06-22 10:50:28 +02:00
Jesse Bye 7e7cec86ac Escape colons in Lunr search query filters 
Signed-off-by: Jesse Bye <jbye@riskalyze.com>
 2021-06-22 10:49:53 +02:00
Oliver Sand 9c8ea7e24e Handle errors in collators and decorators and log them. 
Signed-off-by: Oliver Sand <oliver.sand@sda-se.com>
 2021-06-21 18:22:30 +02:00
Fredrik Adelöw a88073c29a Update copyright headers 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
 2021-06-18 20:26:42 +02:00
Oliver Sand 6f0b0c1a33 Add tests for stemming and trimming 
Signed-off-by: Oliver Sand <oliver.sand@sda-se.com>
 2021-06-16 14:43:25 +02:00
Kevin facbe60532 fix: results are not accurate for search 
Signed-off-by: Kevin <dl_xq@sina.com>
 2021-06-16 15:36:04 +08:00
Eric Peterson 0a032c55ce Fix bug causing search to be empty initially. 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2021-06-04 20:09:28 +02:00
Eric Peterson 8cb45d747a Make the QueryTranslator a more integral part of the SearchEngine API 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2021-06-03 16:28:05 +02:00
Eric Peterson 455b97b127 Make type(s) readonly properties of Collator/Decorator classes 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2021-06-03 16:28:05 +02:00
Eric Peterson b9b26ec572 Update decorator type-specific decorator test 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2021-06-03 16:28:05 +02:00
Eric Peterson f131c3de21 Fix Lunr tests to match new translation logic. 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2021-06-03 16:28:05 +02:00
Emma Indal 720fd2f360 prettier 
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2021-06-03 16:28:04 +02:00
Eric Peterson 1f3e6dff88 Pass result type along from search engine. 
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2021-06-03 16:28:04 +02:00
Emma Indal 8829e8228e wip composable result list 
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2021-06-03 16:28:04 +02:00
Emma Indal 94d1d852e1 update lunr search query filters 
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2021-06-03 16:28:04 +02:00
Emma Indal af6a718e82 change term presence in lunr query 
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
 2021-06-03 16:28:04 +02:00