Commit Graph

7973 Commits

Author SHA1 Message Date
Mike Lewis dbd89112a5 permission-backend: add permission-node integration tests
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:31:42 +00:00
Mike Lewis 2335e0a01f permission-backend: update default port for standalone server
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:31:42 +00:00
Mike Lewis 7f4a77a884 permission-backend: add todo
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:31:42 +00:00
Mike Lewis cd77cbd48f permission-backend: clean up PermissionIntegrationClient applyConditions signature
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:31:42 +00:00
Mike Lewis 6de1e719d4 permission-backend: api docs
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:31:42 +00:00
Mike Lewis 0ce2bc4129 permission-backend: remove manual construction of service discovery
We shouldn't be constructing a service discovery implementation inside
the router, since it removes the ability to provide a different
discovery mechanism.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:31:41 +00:00
Mike Lewis e9b6b7bf89 permission-backend: extract client for calling other plugins to apply conditions
Also adds response validation

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:31:41 +00:00
Mike Lewis 671bf72ed6 permission-backend: fix initial test suite
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:31:41 +00:00
Mike Lewis 4ca6802b97 permission-backend: bump @backstage/cli
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:31:41 +00:00
Mike Lewis be1f89d383 permission-backend: extract AllowAllPermissionPolicy from standaloneServer in permission-backend
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:31:40 +00:00
Mike Lewis 806778d58e permission-backend: fixup api-report
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:31:40 +00:00
Tim Hansen f028746410 Add permission-backend plugin
Signed-off-by: Tim Hansen <timbonicus@gmail.com>
2021-11-24 14:31:40 +00:00
Mike Lewis 370da15e7b permission-node: separate doc comment summaries with @remarks tag
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:30:21 +00:00
Mike Lewis aded9bbc22 permission-node: set version to 0.0.0 before initial release
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:20:56 +00:00
Mike Lewis f5a25ec804 permission-node: fix typo in doc comment
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:19:59 +00:00
Mike Lewis b08dbb1035 permission-node: destructure options inside function to simplify api-report
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-24 14:18:11 +00:00
Mike Lewis 5bff67aac4 permission-node: expose ApplyConditionsResponse type
This type will be shared with the backend.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:36 +00:00
Mike Lewis 3254303a96 permission-node: refactor and split createPermissionIntegration
This refactor makes the createPermissionIntegration system much more
flexible by splitting it up into a few different helpers with different
responsibilities. This frees up plugin authors to connect together the
different parts of the permission integration in whatever way is
convenient for them, and makes the process of registering additional
permission rules a bit more explicit, by requiring them to be passed
in when constructing the systems for transforming or applying
conditions.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
Co-authored-by: Joon Park <joonp@spotify.com>
Co-authored-by: Tim Hansen <timbonicus@gmail.com>
2021-11-22 15:37:35 +00:00
Mike Lewis 70ce7c91e2 permission-node: bump @backstage/cli version
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:35 +00:00
Mike Lewis 0eb339c3a4 permission-node: more visible condition transform in mapCriteria test
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:35 +00:00
Tim Hansen 27d5f5fed3 Improve api-report
Signed-off-by: Tim Hansen <timbonicus@gmail.com>
2021-11-22 15:37:35 +00:00
Mike Lewis 5c5a1d16e4 authz: remove superfluous union type
PermissionCriteria<TQuery> is a union type which already includes
TQuery itself, so we don't need a second union here.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:35 +00:00
Mike Lewis 75dd00c8b6 authz: add missing fields to permission-node package.json
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:35 +00:00
Mike Lewis e2088541dd authz: update references to permission-common after move to plugins
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:34 +00:00
Mike Lewis f72d7bba0e authz: add testsuite for createPermissionIntegration
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:34 +00:00
Mike Lewis 5c75c89106 authz: improve error handling in permission-node apply-conditions route
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:34 +00:00
Mike Lewis 2b668f2eb8 build(deps): add dependency on zod in permission-node
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:34 +00:00
Mike Lewis 22f5de9840 authz: update createPermissionIntegration to work with new PermissionCriteria type
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:34 +00:00
Mike Lewis d0a99e3219 authz: update permission-node api-report
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:34 +00:00
Mike Lewis 64b6ff368f authz: fix expected response type for /apply-conditions route
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:33 +00:00
Mike Lewis 652af0834a authz: add test suite for conditionFor
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:33 +00:00
Mike Lewis f3d2ccfeb8 authz: switch to unknown[] in PermissionRule type parameter
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:33 +00:00
Mike Lewis 4083fcdb5e authz: fix PermissionCondition type parameter
`unknown` doesn't satisfy the (recently added) `extends unknown[]`
constraint. In these two cases, we can remove the parameter entirely and
rely instead on the default of `unknown[]`.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:33 +00:00
Mike Lewis a82709c38f authz: update unused type params in conditionFor to unknown
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-22 15:37:33 +00:00
Tim Hansen a1e2972dda Add permission-node package
Signed-off-by: Tim Hansen <timbonicus@gmail.com>
Co-authored-by: Mike Lewis <mtlewis@users.noreply.github.com>
Co-authored-by: Himanshu Mishra <himanshu@orkohunter.net>
Co-authored-by: Joe Porpeglia <joeporpeglia@users.noreply.github.com>
Co-authored-by: Vincenzo Scamporlino <vinzscam@users.noreply.github.com>
2021-11-22 15:37:32 +00:00
Ainhoa a2e1a008bf Merge pull request #8116 from ainhoaL/user-search-displayname
Add User entities displayName to default catalog collator to be able to search by user's full name
2021-11-22 15:32:26 +00:00
Fredrik Adelöw 1e57d1c23e Merge pull request #8071 from backstage/feat/change-default-port
Change default port of backend from 7000 to 7007
2021-11-22 15:58:48 +01:00
Fredrik Adelöw e62bf29c1d Merge pull request #8069 from goenning/fix-techinsights-docs
Fix techinsights docs: replaced DefaultTechInsightsBuilder with buildTechInsightsContext
2021-11-22 14:41:26 +01:00
Fredrik Adelöw cd3aac016f Merge pull request #7817 from backstage/joonp/entitiessearchfilter-refactor
[Mini PRFC] EntitiesSearchFilter type refactor
2021-11-22 13:48:38 +01:00
Ainhoa Larumbe 4167f6ed7e change uppercase method
Signed-off-by: Ainhoa Larumbe <ainhoaL@users.noreply.github.com>
2021-11-22 12:42:29 +00:00
Ainhoa Larumbe e5bff80f78 uppercase kind
Signed-off-by: Ainhoa Larumbe <ainhoaL@users.noreply.github.com>
2021-11-22 11:45:10 +00:00
Ainhoa Larumbe 73438d1ff1 change methods to private
Signed-off-by: Ainhoa Larumbe <ainhoaL@users.noreply.github.com>
2021-11-22 09:41:09 +00:00
Tim Hansen 2b00e00f18 Merge pull request #8151 from backstage/permission-client-pass-config
permission-common: accept configApi in PermissionClient constructor
2021-11-19 20:18:32 -07:00
Andre Wanlin a519640e67 Rushing, this is the correct change
Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>
2021-11-19 07:34:56 -06:00
Andre Wanlin ab7f280cb4 Fixed missed naming and typos
Signed-off-by: Andre Wanlin <awanlin@rapidrtc.com>
2021-11-19 07:31:10 -06:00
Mike Lewis d1dcd7e309 permission-common: make permission.enabled config optional
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-19 09:36:02 +00:00
Mike Lewis 430b3f7a8f permission-common: accept configApi in PermissionClient constructor
Moving the responsibility of pulling the right configuration key inside
the PermissionClient keeps it as the responsibility of
permission-common, whereas putting it on the outside means anyone
constructing a PermissionClient has to know which key to use.

Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2021-11-19 09:35:09 +00:00
Patrik Oldsberg 0fae9f2c0b core-app-api: fix and release accidental createApp type breakage
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-18 22:54:46 +01:00
Otto Sichert b23bc7f9c3 Change default port of backend to 7007 due to MacOS Control Center update
Signed-off-by: Otto Sichert <git@ottosichert.de>
2021-11-18 16:45:57 +01:00
Fredrik Adelöw fb03c47c8b Merge pull request #8142 from gotson/patch-1
[Doc] fix typos in todo plugin Readme
2021-11-18 15:40:13 +01:00