* 'master' of github.com:spotify/backstage: (139 commits)
Cleanup
Update PinButton.test.tsx
feat: update github insights plugin version (#2973)
Ignore IntelliJ *.iml files (#2971)
chore(deps): bump rollup-plugin-dts from 1.4.11 to 1.4.13
fix the plugin card on plugins page
align 'Add to Marketplace' button on plugins page
fix the PluginGrid on mobiles sizes
use getBy query instead of queryBy when asserting for elements present in document (#2951)
Update PinButton.tsx
Add test case for Progress component (#2953)
fix the styling of footer copy on mobile
add changeset
handle the case where no entities are available to show
core-api: work around issue with ApiRef export const declarations
core-api: move utility api system implementation into apis/system
Update docs regarding npm config ignore-scripts flag
Another try
Fix Core Features configuration id (#2948)
Fix test?
...
* remove data-testid from div
* add test case for Progress component
* add changeset
* update the GraphiQLPage test cases to handle Progress timeout
* update the RadarComponent and RadarPage test case to handle Progress timeout
* update the TechDocsProgressBar test case to handle Progress timeout
* add changeset
* Refactor RadarFooter
* Refactor RadarLegend Pt 1
* Refactor RadarLegend Pt 2
Seeing some errors that I don't fully understand around the proptypes
assertions seemingly being treated as null | undefined values.
It looks like I'll need to type Segment, which is not explicitly
in-scope for this issue.
* Fix segments regression
I incorrectly added type safety to the original implementation, causing
the segments to no longer be populated here. This change fixes that
regression while retaining the type safety.
This is all necessary because qidx and ridx are apparently both
nullable.
* Resolve remaining RadarLegend warnings
* Refactor RadarEntry
* Forcibly skip hooks to revert migration prettify
* Refactor RadarGrid
* Refactor RadarPlot & Best effort with PropTypes
A global search looks like no other plugins use PropTypes. I'm about to
remove them in the next commit because shapes don't seem to cooperate
with TypeScript, making the PropTypes either so vague that they're
mostly useless or specific enough to fail the build.
With that said, I wanted to get this version committed in case I need to
roll back to here. I wouldn't want to redo this work.
* Remove PropTypes from refactored components
The build now passes.
* Refactor RadarBubble
* Refactor Radar
* Move Radar functions out of component file
I could see these being split into separate files, but I think this is
enough for now.
* Small function signature change
* Align types
I'm not confident in this change. I'm very unclear about the reasoning
behind the type definitions in api.ts as they don't reflect the shape of
the values that I see when I print `data.entries` in the console.
The value of data.entries reflects a fully-populated Entry[], not a
RadarEntry[].
As such, I'm also not sure about the sample data. I would be more
hesitant to updated it, but the fact that the rest of the components
seem to be expecting that data makes it seem fairly clear that it must
be required to be in the updated shape.
o-farooq