Commit Graph

63 Commits

Author SHA1 Message Date
Eric Peterson 0fcbe29c6b Clarify typeguard usage
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2023-01-10 11:34:11 +01:00
Eric Peterson 2a49ffbcb3 Clean up / improve client instantiation docs.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2023-01-09 13:29:39 +01:00
Eric Peterson 1e1a9fe979 Prevent the readiness check from looping endlessly
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-12-22 14:09:49 +01:00
Eric Peterson aa33a06894 Optimize indexer throughput
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-12-22 12:49:09 +01:00
Eric Peterson 56633804dd Gracefully handle client-level (vs. response-level) errors
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-12-22 11:15:38 +01:00
Joe Patterson 011bd518b7 Update docs for all spelling errors, and add auth0 session and spec.presence
Signed-off-by: Joe Patterson <jrwpatterson@gmail.com>
2022-12-20 16:50:51 +01:00
Eric Peterson e2c798e31c Merge pull request #14938 from backstage/search/resilient-indices
[Search] Preserve existing index if latest index run contains no documents
2022-12-15 15:24:11 +01:00
Renan Mendes Carvalho 0bc908d0eb fix(plugins-search-backend-module-elasticsearch): Missing node config
This patch fixes the engine creation by adding the missing and
necessary config: node.

Co-authored-by: Camila Belo <camilaibs@gmail.com>
Signed-off-by: Renan Mendes Carvalho <aitherios@gmail.com>
2022-12-13 13:50:00 +01:00
Renan Mendes Carvalho 717bd13875 plugin-search-backend-module-elasticsearch: Opensearch provider
This patch continues the work started by jinnjwu on
https://github.com/backstage/backstage/pull/14988

It creates a new provider, opensearch, allowing the usage of it
outside of managed aws solutions.

Signed-off-by: Renan Mendes Carvalho <aitherios@gmail.com>
2022-12-13 13:50:00 +01:00
Eric Peterson d75d73d33b Clearer test assertions
Co-authored-by: Renan Mendes Carvalho <aitherios@gmail.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-12-02 11:46:47 +01:00
Eric Peterson 35af08d9a0 Update elastic engine to preserve pre-existing indices if indexer receives 0 documents
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-12-02 09:44:37 +01:00
Eric Peterson 45eb4d23cf Be persistent in attempting to clean up indices on error
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-11-30 15:47:49 +01:00
Eric Peterson 9467500482 Merge pull request #14794 from philberryman/feat/analytics-number-of-search-results
add number of searches
2022-11-30 12:09:14 +01:00
Eric Peterson aff7351fa5 Use non-deprecated TestPipeline static methods
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-11-25 15:22:32 +01:00
Phil Berryman 29ebc43a0b feat: add number of searches
Signed-off-by: Phil Berryman <phil@berryman.org.uk>
2022-11-25 00:13:05 -08:00
Eric Peterson 8006f8a602 Tag indexing logs with document type
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-10-10 18:02:33 +02:00
Camila Belo 60a912cd2c Rename param to page limit and validate its type
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-10-04 10:54:09 +02:00
Emma Indal 814c8a61f6 Search engines to use resultPerPage param if provided
Co-authored-by: Camila Loiola <camilaibs@gmail.com>
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-10-04 10:54:09 +02:00
Fredrik Adelöw aaab1e34da Fix linting errors after #13392
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-08-30 13:44:09 +02:00
Fredrik Adelöw ef9ab322de it just keeps 🧹 -ing
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-08-18 17:21:00 +02:00
Eric Peterson a84aef3e1e Merge pull request #12534 from nodify-at/master 2022-07-18 11:36:58 +02:00
Eric Peterson c80d547dff Ignore most likely irrelevant typescript issues.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-07-08 17:13:32 +02:00
Hasan Oezdemir ab338422e1 Feature: add a new option to set the batch size for elastic search engine, if not given the default batch size is 1.000
Signed-off-by: Hasan Oezdemir <21654050+nodify-at@users.noreply.github.com>
2022-07-08 12:39:22 +02:00
Camila Belo dcba440459 refactor: apply review suggestions
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-07-05 12:02:21 +02:00
Emma Indal faa5dde25e feedback fixups
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-07-01 09:30:47 +02:00
Camila Belo 19bcc9d795 feat(search-backend-module-es): test error handling
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-06-28 13:46:13 +02:00
Emma Indal 197bca1bc0 Merge branch 'master' into emmai/search-error-handling 2022-06-28 13:01:11 +02:00
Eric Peterson 7a90b62aad Test the new client wrapper.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-06-27 13:51:55 +02:00
Eric Peterson 68b7739aab Refactor Elasticsearch client calls into client wrapper and break out types
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-06-27 13:50:44 +02:00
Emma Indal 34c97eb35b switch to use .json instead of .send
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-06-22 14:06:09 +02:00
Emma Indal c30ecd900f ElasticSearch engine throw MissingIndexError if error type is index_not_found_exception
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-06-20 15:48:44 +02:00
Eric Peterson c7ce7b1eb0 Test rank handling in all search engines.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-06-10 15:36:11 +02:00
Eric Peterson 915700f64f Set a pagination-aware rank value for all search engines.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-06-10 15:36:11 +02:00
Emma Indal 0b8c1b93e2 setIndexTemplate to be directly responsible for calling putIndexTemplate
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-06-10 13:31:46 +02:00
Emma Indal 7c26e81120 add some more docs to the template body type as well as optional composed_of
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-06-10 10:33:29 +02:00
Emma Indal 535847cf14 changeset and api report updates
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-06-10 10:08:48 +02:00
Emma Indal 1b59892019 implement possibilities to set custom template on elastic search engine
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-06-10 10:03:25 +02:00
Emma Indal 28972473a0 rename ConcreteElasticSearchQuery -> ElasticSearchConcreteQuery
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-06-03 14:12:39 +02:00
Emma Indal 0afede342d clean up api report for search-backend-module-elasticsearch package
Signed-off-by: Emma Indal <emma.indahl@gmail.com>
2022-06-02 13:10:40 +02:00
Phil Kuang 281cec1b61 fix(elasticSearch): use more precise matching for query filters
Signed-off-by: Phil Kuang <pkuang@factset.com>
2022-05-27 10:00:55 -04:00
Phil Kuang 9eef9c9db4 fix(elasticSearch): do not define pageCursor on last page
Signed-off-by: Phil Kuang <pkuang@factset.com>
2022-05-12 21:32:44 -04:00
Fredrik Adelöw 16dcf2a807 Merge pull request #10981 from kuangp/feat/search/highlight
feat(search): highlight search result terms
2022-05-09 18:27:07 +02:00
Phil Kuang 3a74e203a8 feat(search): highlight search result terms
Signed-off-by: Phil Kuang <pkuang@factset.com>
2022-05-09 11:13:34 -04:00
Eric Peterson 71d3432710 Set the default batchSize to 1000 for all search engines.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-05-01 16:19:58 +02:00
Phil Kuang a7f7a63d14 refactor(elasticsearch): support retrying failed deletion of stale indices
Signed-off-by: Phil Kuang <pkuang@factset.com>
2022-04-19 11:58:51 -04:00
Mike Lewis 62ee65422c elasticsearch: use new IndexableResultSet type as return type of engine#query
Signed-off-by: Mike Lewis <mtlewis@users.noreply.github.com>
2022-03-17 12:39:41 +00:00
Eric Peterson 3e54f6c436 Use @backstage/plugin-search-common instead of @backstage/search-common
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-03-04 18:47:55 +01:00
Eric Peterson 2c171166a0 Update ElasticSearchSearchEngine to be stream-based
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-03-02 17:26:58 +01:00
Charles Lowell c47959856a Don't use initializer syntax for instantiating client
For some reason, the property initializer syntax stopped working. An
update to TypeScript? An update to Jest? Unknown, but sticking to the
less fancy constructor body to do property init seems to work.

Signed-off-by: Charles Lowell <cowboyd@frontside.com>
2021-12-15 15:30:30 +02:00
Charles Lowell 5515862338 Run api report and add minimal tsdoc.
Signed-off-by: Charles Lowell <cowboyd@frontside.com>
2021-12-14 20:39:55 +02:00