Commit Graph

52 Commits

Author SHA1 Message Date
Sayak Mukhopadhyay bdfe792890 fix: prettyfying things
Signed-off-by: Sayak Mukhopadhyay <mukhopadhyaysayak@gmail.com>
2022-12-29 19:04:25 +05:30
Sayak Mukhopadhyay 94b4ab688d refactor: simplify coersion of type to string
Co-authored-by: Ben Lambert <blam@spotify.com>
Signed-off-by: Sayak Mukhopadhyay <mukhopadhyaysayak@gmail.com>
2022-12-29 17:06:33 +05:30
Sayak Mukhopadhyay bfd1161dcf refactor: simplify returns
Signed-off-by: Sayak Mukhopadhyay <mukhopadhyaysayak@gmail.com>
2022-12-28 22:03:19 +05:30
Sayak Mukhopadhyay 74eed91f5b tests: remove test for invalid number 0 for boolean as it is coerced now
Signed-off-by: Sayak Mukhopadhyay <mukhopadhyaysayak@gmail.com>
2022-12-28 21:38:01 +05:30
Sayak Mukhopadhyay 57e91a24b9 feat: coerce some strings and numbers into boolean
Signed-off-by: Sayak Mukhopadhyay <mukhopadhyaysayak@gmail.com>
2022-12-28 21:30:49 +05:30
Sayak Mukhopadhyay 485ccd98fb test: add tests for coercing some strings and numbers to boolean
Signed-off-by: Sayak Mukhopadhyay <mukhopadhyaysayak@gmail.com>
2022-12-28 21:30:49 +05:30
Sayak Mukhopadhyay ac1e91c252 feat: handle string representation of boolean values in the config
Signed-off-by: Sayak Mukhopadhyay <mukhopadhyaysayak@gmail.com>
2022-12-28 21:30:48 +05:30
Sayak Mukhopadhyay 8e489d089e test: add tests for string representation of booleans in config
Signed-off-by: Sayak Mukhopadhyay <mukhopadhyaysayak@gmail.com>
2022-12-28 21:30:47 +05:30
Patrik Oldsberg 72d4b7061d Merge pull request #8719 from cmpadden/warn-app-config-deprecations
Warn users of deprecated keys in app configurations
2022-01-13 23:25:01 +01:00
Patrik Oldsberg f5343e7c1a config: make get always return a clone
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-01-08 16:26:31 +01:00
Patrik Oldsberg a95e788059 config: move reader test to correct block
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-01-08 16:26:31 +01:00
Colton Padden a505347140 enable withDeprecatedKeys in schema process for backend-common and app-backend
Signed-off-by: Colton Padden <colton.padden@fastmail.com>
2022-01-05 14:17:11 -05:00
Colton Padden 63fa8f8371 move deprecation description key mapping into filterByVisibility
Signed-off-by: Colton Padden <colton.padden@fastmail.com>
2022-01-04 16:24:06 -05:00
Colton Padden 1136ed83e3 wip: warn users of deprecated keys in app configurations
Signed-off-by: Colton Padden <colton.padden@fastmail.com>
2022-01-02 11:39:33 -05:00
Fredrik Adelöw 10d267a1b7 Minor fix for the config package too
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-10-26 19:36:17 +02:00
Johan Haals 49252f0d6d Merge pull request #7727 from backstage/test-utils-core
Move test-utils-core into test-utils
2021-10-25 11:09:16 +02:00
Johan Haals 925a967f36 Replace usage of test-utils-core with test-utils
Signed-off-by: Johan Haals <johan.haals@gmail.com>
2021-10-22 09:39:21 +02:00
Fredrik Adelöw 447c514899 rename to just types
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-10-21 15:18:37 +02:00
Fredrik Adelöw 41c49884d2 introduce core-types
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-10-21 09:45:32 +02:00
Fredrik Adelöw e9f332a51c Restrict imports on the form ../../plugins/x/src
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-09-20 13:55:44 +02:00
Patrik Oldsberg 8142a8ecb2 packages,plugins: add package documentation
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-09-14 18:47:53 +02:00
Patrik Oldsberg f88b2c7dbe config: document interface and mark types as public
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-09-04 22:42:47 +02:00
Fredrik Adelöw 47113f1f19 Only warn once per key when trying to read visibility-filtered values
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-08-26 08:09:57 +02:00
Patrik Oldsberg 90f25476ac config,backend-common: move config subscribe method to the base config interface
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-08-16 10:41:07 +02:00
Fredrik Adelöw 923491eece run prettier formatting
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-08-09 11:54:38 +02:00
Patrik Oldsberg e9d3983eee config,config-loader: warn when trying to access invisible config values
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-08-01 13:12:20 +02:00
Fredrik Adelöw a88073c29a Update copyright headers
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-06-18 20:26:42 +02:00
Fredrik Adelöw 0434853a56 Reformulate the json types to break type recursion
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-03-15 21:32:29 +01:00
Andrew Thauer 0f1e10b101 fix(config): ensure config type reflects get<T> 2021-02-21 15:13:22 -05:00
Andrew Thauer a1f5e65452 feat(config): support native casting for get functions 2021-02-21 09:52:50 -05:00
Patrik Oldsberg 1da7d2c657 plugins,packages: replace usages of ConfigReader.from 2020-12-15 19:04:50 +01:00
Adam Harvey 6fde301a99 FIx unneeded defensive code 2020-12-09 15:56:27 -05:00
Patrik Oldsberg 265be1d6a1 config: try to coerce string values into numbers 2020-09-03 16:35:16 +02:00
Taras Mankovski 3877a50ce9 Remove unnecessary line 2020-09-03 08:30:40 -04:00
Taras Mankovski f955f92ee6 Add failed test for coercion of numberic strings 2020-09-03 08:06:08 -04:00
Patrik Oldsberg 9c436febb0 config: add missing methods to Config type 2020-08-25 15:50:33 +02:00
Patrik Oldsberg f8780ff325 config: allow config.get to be called without args 2020-08-08 12:07:37 +02:00
Patrik Oldsberg 12827a29dc config: added config.has() 2020-08-08 11:56:30 +02:00
Patrik Oldsberg 1f2216fd77 config: flip priority order of ConfigReader.fromConfigs 2020-08-07 16:43:33 +02:00
Fredrik Adelöw 3bff1d6a68 address comments 2020-06-18 13:28:19 +02:00
Patrik Oldsberg 02b74c376a packages/config: added get and getOptional 2020-06-18 11:59:53 +02:00
Patrik Oldsberg 32a4da583c packages/config: add getOptionalConfig and getOptionalConfigArray to mirror other accessors 2020-06-18 11:03:42 +02:00
Patrik Oldsberg ef4991fc2b packages/config: added context to keep track of where config is from for error messages 2020-06-17 20:18:07 +02:00
Patrik Oldsberg 8cda915c70 packages/config: added .keys() 2020-06-17 20:17:39 +02:00
Patrik Oldsberg 625a50989d packages/config: keep track of key prefix to display better error messages 2020-06-17 20:17:24 +02:00
Patrik Oldsberg 5294d71fe9 packages/config: optimize some error message handling 2020-06-17 20:17:24 +02:00
Patrik Oldsberg c9ee24b8bb packages/config: allow config readers to be backed by undefined data 2020-06-17 20:17:24 +02:00
Patrik Oldsberg 3dcef70e3c packages/config: flip around must* and get* to get* and getOptional* 2020-06-17 20:10:44 +02:00
Patrik Oldsberg 31585800a4 packages/config: added must* variant for reading required primitive values 2020-06-17 17:17:19 +02:00
Patrik Oldsberg 650779412c packages/config-loader: add build- and dev-time config through env + tests 2020-06-06 17:06:47 +02:00