Commit Graph

575 Commits

Author SHA1 Message Date
Patrik Oldsberg db2e137744 remove unnecessary usages of ThemeProvider
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-12-31 18:24:32 +01:00
Ben Lambert 4100f670b0 Merge pull request #14965 from kuangp/fix/techdocsLog
fix(TechDocsBuildLogs): properly render entire log
2022-12-28 16:44:46 +01:00
Morgan e567de03a1 add another test
Signed-off-by: Morgan <mbentell@spotify.com>
2022-12-20 10:03:48 +01:00
Morgan 665c681f3c fix tests that broke
Signed-off-by: Morgan <mbentell@spotify.com>
2022-12-20 09:55:50 +01:00
Morgan Bentell 028f88ecb4 Update test string
Signed-off-by: Morgan Bentell <morgan.bentell@gmail.com>
2022-12-19 18:06:41 +01:00
Morgan 6aa2b965eb when looking for the page within the outlet, reject addons wrapper as well as addons, because different versions of react router use different numbers of wrappers. Should be compatible with all 6.* versions now
Signed-off-by: Morgan <mbentell@spotify.com>
2022-12-19 17:48:13 +01:00
Carlos Esteban Lopez 87cbf39fa1 fix: Fix button linter rules
Signed-off-by: Carlos Esteban Lopez <lcarlosesteb@vmware.com>
2022-12-13 11:37:14 -05:00
Patrik Oldsberg 530a1f1299 plugins: replace react-router mocks with react-router-dom
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-12-12 21:30:57 +01:00
Patrik Oldsberg 2e701b3796 refactor react-router -> react-router-dom
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-12-10 15:17:53 +01:00
Phil Kuang a74dd61534 fix(TechDocsBuildLogs): properly render entire log
Signed-off-by: Phil Kuang <pkuang@factset.com>
2022-12-07 21:54:15 -05:00
Patrik Oldsberg 3ad5d36e52 Merge pull request #14615 from jsundquist/master
fix(search): update to only link title in search results
2022-11-28 15:10:38 +01:00
Fredrik Adelöw 3bd6cc7c55 some more progress toward ubiquitous eslint-plugin-testing-library
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-11-23 09:28:37 +01:00
Fredrik Adelöw d3fea4ae0a avoid globals
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-11-22 15:42:29 +01:00
Fredrik Adelöw cb716004ef add some eslint rules for testing-library use in tests
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-11-18 11:29:20 +01:00
Jonathan Sundquist 81e945d052 move link outside of ternary
Signed-off-by: Jonathan Sundquist <jonathan.sundquist@factset.com>
2022-11-15 09:24:28 -06:00
Patrik Oldsberg 7ac593e8d3 Merge pull request #14075 from ilteoood/fix/14026
fix: page hader
2022-11-15 09:19:31 +01:00
Jonathan Sundquist a19cffbeed fix(search): update to only link title in search results
Signed-off-by: Jonathan Sundquist <jonathan.sundquist@factset.com>
2022-11-14 10:16:44 -06:00
Anders Näsman e984e9018f Merge pull request #14256 from omerfarukdogan/master
feat(docs): hide document description if not provided
2022-11-14 14:05:18 +01:00
Eric Peterson bd2aab4726 Capture 'click' event on link clicks within TechDocs dom
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2022-11-11 12:00:37 +01:00
Ömer Faruk Doğan 63705e73d9 feat(docs): hide document description if not provided
Signed-off-by: Ömer Faruk Doğan <8117265+omerfarukdogan@users.noreply.github.com>
2022-11-10 16:58:21 +03:00
Matteo Pietro Dazzi 22719b8812 Merge remote-tracking branch 'backstage/master' into fix/14026 2022-10-26 22:12:33 +02:00
Matteo Pietro Dazzi f5ab2bc24c fix: capitalize
Signed-off-by: Matteo Pietro Dazzi <matteopietro.dazzi@gmail.com>
2022-10-26 22:12:18 +02:00
Matteo Pietro Dazzi 9a2088fb8c refactor: position
Signed-off-by: Matteo Pietro Dazzi <matteopietro.dazzi@gmail.com>
2022-10-26 22:12:18 +02:00
Otto Sichert cc8701d2fb Add documentation for configuring TechDocsReaderPage
Signed-off-by: Otto Sichert <git@ottosichert.de>
2022-10-25 17:38:43 +02:00
Morgan 5878dcd120 remove unused import
Signed-off-by: Morgan <mbentell@spotify.com>
2022-10-25 16:39:57 +02:00
Morgan 1a22b5f1b1 rewrite loop code
Signed-off-by: Morgan <mbentell@spotify.com>
2022-10-25 16:27:03 +02:00
Morgan 431ecaf1d5 this seems to solve the issue. actually get the nested element instead of the parent of that element
Signed-off-by: Morgan <mbentell@spotify.com>
2022-10-25 16:27:03 +02:00
Fredrik Adelöw 52d168b6a1 Merge pull request #14312 from backstage/freben/circ
get rid of circular imports
2022-10-25 10:46:52 +01:00
Fredrik Adelöw 7573b65232 get rid of circular imports
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-10-25 11:00:05 +02:00
Simon Ninon 5691baea69 plugin-techdocs: add group filtering support to EntityListDocsGrid
Signed-off-by: Simon Ninon <sninon@pagerduty.com>
2022-10-24 10:34:57 -07:00
Fredrik Adelöw cbe11d1e23 just getting rid of vale warnings
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-10-22 17:18:47 +02:00
Johan Haals 2e9329831f Merge pull request #14192 from Bonial-International-GmbH/pjungermann/github/naming-part2
chore(integration): use consistent naming of `[gG]ithub` in code
2022-10-20 09:41:56 +02:00
Patrick Jungermann c1784a4980 chore(integration): use consistent naming of [gG]ithub in code
Relates to the discussion at PR #14039.

Relates-to: PR #14039
Relates-to: PR #14174
Signed-off-by: Patrick Jungermann <Patrick.Jungermann@gmail.com>
2022-10-19 16:11:53 +02:00
Phil Kuang 3a1a999b7b fix(techdocsReader): include search params when navigating urls
Signed-off-by: Phil Kuang <pkuang@factset.com>
2022-10-13 11:33:17 -04:00
Matteo Pietro Dazzi c62fa237d8 fix: use entity as fallback
Signed-off-by: Matteo Pietro Dazzi <matteopietro.dazzi@gmail.com>
2022-10-11 17:33:46 +02:00
Matteo Pietro Dazzi 847fc588a6 fix: page hader
Signed-off-by: Matteo Pietro Dazzi <matteopietro.dazzi@gmail.com>
2022-10-11 13:36:40 +02:00
Anders Näsman 4c33b249a0 Merge pull request #13527 from drankou/drankou/techdocs-scroll-fix
fix(techdocs): Fix scrolling for anchors on the current page
2022-09-06 11:53:33 +02:00
Patrik Oldsberg 7a95c705fa techdocs: fix addons not rendering on subpages with react router v6
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-09-05 12:30:19 +02:00
drankou e97d616f08 Fix scrolling for anchors on the current page
Signed-off-by: drankou <aliaksandr.drankou@productboard.com>
2022-09-05 10:56:27 +02:00
Camila Belo ca8d5a6eae refactor: apply review suggestions
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-09-01 12:39:45 +02:00
Fredrik Adelöw aaab1e34da Fix linting errors after #13392
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-08-30 13:44:09 +02:00
Patrik Oldsberg 9f1feb5464 plugins: fix tests for react router bump
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: blam <ben@blam.sh>
Co-authored-by: Johan Haals <johan.haals@gmail.com>
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-08-29 14:10:52 +02:00
Patrik Oldsberg 763fb81e82 refactors to avoid using useParams where possible
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-08-23 18:43:26 +02:00
blam 1de5594c75 chore: reworking tests for swc
Signed-off-by: blam <ben@blam.sh>
2022-08-23 10:53:05 +02:00
blam 658d6ab0e7 chore: fixing all tests
Signed-off-by: blam <ben@blam.sh>
2022-08-23 10:53:04 +02:00
blam 1826f15069 chore: reworking
Signed-off-by: blam <ben@blam.sh>

Signed-off-by: blam <ben@blam.sh>
2022-08-23 10:53:04 +02:00
Emma Indal 9d02b5e887 Merge pull request #13125 from backstage/camilaibs/fix-techdocs-title-subtitle
[TechDocs] Update title and subtitle when location changes
2022-08-22 16:56:57 +02:00
Fredrik Adelöw ef9ab322de it just keeps 🧹 -ing
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-08-18 17:21:00 +02:00
Fredrik Adelöw 3f739be9d9 more api cleanup
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2022-08-18 15:16:19 +02:00
Camila Belo 829f14a9b0 fix(techdocs): to update title and subtitle when location changes
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2022-08-12 15:27:25 +02:00