Commit Graph

14297 Commits

Author SHA1 Message Date
Patrik Oldsberg b62c7f7e65 Merge pull request #15193 from scprek/add-links-to-sonarqube-be-fe
Add links in README to reference Sonarqube FE/BE
2022-12-19 16:57:39 +01:00
Ben Lambert 06913228d6 Merge pull request #15261 from dagda1/bump-rjsf-v5-dependencies
bump @rjsf/*-v5 dependencies
2022-12-19 13:59:37 +01:00
Ben Lambert 46c0fdb428 Merge pull request #14702 from alexrybch/scaffolder-ui-options
initial support of ui options in scaffolder forms
2022-12-19 13:29:31 +01:00
Ben Lambert 06298b1b37 Merge pull request #14700 from alexrybch/validator-form-data
added formData to validation function
2022-12-19 13:25:45 +01:00
Johan Haals 4ea7aa017f Merge pull request #15276 from backstage/renovate/kubernetes-client-node-0.x
Update dependency @kubernetes/client-node to v0.18.0
2022-12-19 13:09:45 +01:00
Johan Haals 2441429c59 Merge pull request #15262 from cchawn/rails-scaffolder-arguments
feat(scaffolder-backend-module-rails): handle more rails new arguments
2022-12-19 11:43:07 +01:00
Steve Cprek 385339ee2a Add links in README to reference Sonarqube FE/BE
Signed-off-by: Steve Cprek <steve.cprek@favordelivery.com>
2022-12-18 22:42:23 -06:00
Johan Haals 1d745054fa Merge pull request #15145 from backstage/jhaals/catalog-openTelemetry
catalog: register OpenTelemetry metrics, deprecate prom-client
2022-12-16 14:32:01 +01:00
renovate[bot] 9ce7866ecd Update dependency @kubernetes/client-node to v0.18.0
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2022-12-16 13:22:04 +00:00
Johan Haals b93177ac7f Merge pull request #15223 from sfc-gh-kleonhard/github-require-resolved-convos
Add support for enabling Github's "require resolved conversations" option
2022-12-16 13:55:44 +01:00
Fredrik Adelöw 5e5f5f9b24 Merge pull request #15240 from LANGERGabrielle/fix/lighthouse-7-form-factor
plugin-lighthouse: fix form factor field not working
2022-12-16 11:15:00 +01:00
Fredrik Adelöw d19420d3ca Merge pull request #15037 from luchillo17/feat/BCKSTG-93-linter-rules
Enable eslint-plugin-react with recommended settings & forbid button
2022-12-16 11:10:49 +01:00
Fredrik Adelöw 5e79c64bae Merge pull request #15212 from backstage/freben/circ-emit
ignore processors emitting entities that are their own children
2022-12-16 10:39:33 +01:00
Fredrik Adelöw ba9ae05052 Merge pull request #14940 from estherannorzie/master
Home: Update starred entities' default message to and provide optional prop to override it
2022-12-15 22:21:21 +01:00
Fredrik Adelöw 725cd72496 Merge pull request #14314 from magnusp/sonarqube-public-api
Expose SonarQube API and helpers
2022-12-15 22:17:30 +01:00
Christina Chan 27b23a86ad feat(scaffolder-backend-module-rails): handle more rails new arguments
Signed-off-by: Christina Chan <6462356+cchawn@users.noreply.github.com>
2022-12-15 15:52:00 -05:00
Fredrik Adelöw ce23b273a1 Merge pull request #15250 from jamieklassen/node-fetch-k8s
[kubernetes] use node-fetch and gracefully surface fetcherrors
2022-12-15 21:21:30 +01:00
Paul Cowan 380f549b75 bump @rjsf/*-v5 dependencies
Signed-off-by: Paul Cowan <paul.cowan@cutting.scot>
2022-12-15 19:20:31 +00:00
Eric Peterson e2c798e31c Merge pull request #14938 from backstage/search/resilient-indices
[Search] Preserve existing index if latest index run contains no documents
2022-12-15 15:24:11 +01:00
Fredrik Adelöw a29773b2cd Merge pull request #14980 from iriswang233/Track-the-last-time-the-final-entity-changed
Track the last time the final entity changed
2022-12-15 11:17:57 +01:00
iris b568378cf8 add migration testing for 20221201085245_add_last_updated_at_in_final_entities
Signed-off-by: iris <hellocomplex007@gmail.com>
2022-12-15 15:44:09 +08:00
iris 860fbcde3b add ts-check
Signed-off-by: iris <hellocomplex007@gmail.com>
2022-12-15 15:30:52 +08:00
iris bcd800bb33 make last_updated_at optional
Signed-off-by: iris <hellocomplex007@gmail.com>
2022-12-15 15:29:20 +08:00
Jamie Klassen 7341131af5 warning is a full sentence mentioning cluster name
This seems like a more helpful log message for operators, especially those
with many clusters.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-12-14 17:51:19 -05:00
Jamie Klassen b008ccee54 throw when missing token and not on k8s
Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-12-14 17:51:19 -05:00
Jamie Klassen bacb5470b6 frontend displays new error types
Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-12-14 17:51:19 -05:00
Jamie Klassen a5a9d3318a don't surface non-FetchErrors
It makes sense to gracefully show an error that was actually related to fetching
data from Kubernetes, but if the error is happening for some other exotic
reason, the default error handling logic in Backstage should take over and
log/manage it appropriately.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-12-14 17:51:19 -05:00
Jamie Klassen 0ad476a720 gracefully surface FetchErrors
Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-12-14 17:51:19 -05:00
Jamie Klassen fcf8d33014 node-fetch-based implementation for pod metrics
which eliminates the need for the KubernetesClientProvider

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-12-14 17:51:19 -05:00
Jamie Klassen f54362ad57 use node-fetch for k8s resources
The main advantage this has over using the list*CustomObject methods is that it
won't reject non-OK statuses, so we won't have to be so careful about
catching and rethrowing.

Personally I find it a bit clearer to see the actual requests rather than the
client methods with all those empty arguments, and a side benefit is that this
implementation uses the fetch API -- under the covers, @kubernetes/client-node
is using the deprecated request library.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-12-14 17:51:19 -05:00
Jamie Klassen 99ca12978d spy on https calls to check caData
This is a little awkward, but at the moment msw doesn't give much of a means of
interacting with the non-WHATWG-Fetch-spec aspects of a request.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-12-14 17:51:19 -05:00
Jamie Klassen df716f5ed5 metrics tests use msw instead of mocks
Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-12-14 17:51:19 -05:00
Jamie Klassen 7e2cd3c357 backfill test for warning log
Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-12-14 17:51:19 -05:00
Jamie Klassen 030f9cb5c1 backfill test for non-kubernetes error
Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-12-14 17:51:19 -05:00
Jamie Klassen 15ad4b2389 stub k8s API checks bearer tokens
Also, use idiomatic ResponseTransformers to clean up the individual tests.
Finally, modify the "unauthorized error handling" spec to provide an invalid
token to an otherwise-realistic stub k8s API.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-12-14 17:51:19 -05:00
Jamie Klassen d31fe28625 backfill test for loading default kubeconfig
Strictly speaking, the `loadFromDefault` method on `KubeConfig` as it is
being called in `KubernetesClientProvider` has many other behaviours that this
test does not exercise -- it has logic for reading kubeconfig files (based on
an env var or default location in a home directory), provisions for running on
Windows, and even contacting an apiserver on localhost.

I'm making a breaking assumption here that these other scenarios are not
important for Backstage users, and the one that really matters is the
in-cluster one described in this test.

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-12-14 17:51:19 -05:00
Jamie Klassen f7ccaef866 convert fetchObjectsForService mocks to msw
this will allow some dramatic refactoring

Signed-off-by: Jamie Klassen <jklassen@vmware.com>
2022-12-14 17:51:19 -05:00
Magnus Persson 836b30e61c Update api-report.md
Signed-off-by: Magnus Persson <magnus.persson@fortnox.se>
2022-12-14 22:27:27 +01:00
Magnus Persson 19f8ad4262 Keep types but marked deprecated
Signed-off-by: Magnus Persson <magnus.persson@fortnox.se>
2022-12-14 22:27:27 +01:00
Magnus Persson b3a304e78e Reference @backstage/plugin-sonarqube-react from @backstage/plugin-sonarqube
Signed-off-by: Magnus Persson <magnus.persson@fortnox.se>
2022-12-14 22:27:27 +01:00
Magnus Persson 2b555e3b83 Add @backstage/plugin-sonarqube-react
Signed-off-by: Magnus Persson <magnus.persson@fortnox.se>
2022-12-14 22:27:27 +01:00
Kyle Leonhard e0e49bb0b2 Add tests
Signed-off-by: Kyle Leonhard <kyle.leonhard@snowflake.com>
2022-12-14 09:55:45 -08:00
Gabrielle Langer 226099ad03 fix(plugin-lighthouse): incorporate feedback and add unit tests
Signed-off-by: Gabrielle Langer <gabrielle.langer.ext@corp.ovh.com>
2022-12-14 18:10:04 +01:00
Patrik Oldsberg a219b735dc Merge pull request #15237 from backstage/mob/config-obj
backend-plugin-api: suffix all service interfaces with *Service
2022-12-14 17:55:31 +01:00
Fredrik Adelöw 8bb1931b24 Merge pull request #15178 from gtestault/feature/jenkins_standalone_project
Feature/jenkins standalone project
2022-12-14 16:32:35 +01:00
Gabrielle Langer e3dfef3f63 fix(plugin-lighthouse): fix form factor field in the audit creation form not working with the latest version of lighthouse-audit-service
Signed-off-by: Gabrielle Langer <gabrielle.langer.ext@corp.ovh.com>
2022-12-14 15:51:31 +01:00
Patrik Oldsberg 05a928e296 fix breakages from Service interface renames
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2022-12-14 15:03:02 +01:00
Gabriel Testault 6c70d769e4 feature(jenkins-backend): be more precise in jenkins terminology
Only explicitly support Multibranch Pipeline and Pipeline projects

Signed-off-by: Gabriel Testault <gabriel.testault@goto.com>
2022-12-14 12:02:27 +01:00
Gabriel Testault 98ba60b8b5 feature(jenkins-backend): improve test for standalone project
test that the client is called twice for unfiltered standalone projects.

Signed-off-by: Gabriel Testault <gabriel.testault@goto.com>
2022-12-14 11:29:44 +01:00
Kyle Leonhard 7ef9bf8c6e Add option to require Github conversation resolution
Signed-off-by: Kyle Leonhard <kyle.leonhard@snowflake.com>
2022-12-13 15:54:23 -08:00