paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 27 Packages Projects Releases Wiki Activity
23,729 Commits 1 Branch 0 Tags
5da4d0cfbd9feccdca1be3e2f7129a3c6edd4a6e
Commit Graph

1262 Commits

Author SHA1 Message Date
Fredrik Adelöw 36aa63022b deprecate EntityName, introduce CompoundEntityRef 
deprecate getEntityName, introduce getCompoundEntityRef

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
 2022-03-02 21:54:45 +01:00
Patrik Oldsberg 6ed03eeacb Merge pull request #9782 from Bonial-International-GmbH/PJ_bitbucket_default-apiBaseUrl 
feat(bitbucket): ensure apiBaseUrl, replace hardcoded cases
 2022-03-02 17:35:12 +01:00
Fredrik Adelöw 83a83381b0 rearrange 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
 2022-03-01 14:44:59 +01:00
blam 5c7f2343ea chore: port the fix back to mainline 
Signed-off-by: blam <ben@blam.sh>
 2022-02-25 16:42:40 +01:00
blam 6c66fe1130 bug: repoUrl does not have a protocol 
Signed-off-by: blam <ben@blam.sh>

Signed-off-by: blam <ben@blam.sh>
 2022-02-25 16:39:27 +01:00
Patrick Jungermann 34af86517c feat(bitbucket): ensure apiBaseUrl, replace hardcoded cases 
Ensure presence of apiBaseUrl for bitbucket
integrations for both cases Bitbucket Cloud and
Bitbucket Server by setting the default for
Bitbucket Server at the integration config, too.

Replace hardcoded uses of the default apiBaseUrl
with the use of the integration config's value.

Signed-off-by: Patrick Jungermann <Patrick.Jungermann@gmail.com>
 2022-02-25 15:18:17 +01:00
Nicolas Arnold 2974c56168 Set timeout as const variable per comments 
Signed-off-by: Nicolas Arnold <nic@roadie.io>
 2022-02-25 14:03:17 +00:00
Nicolas Arnold 1f0fc6db69 Changing the timeout value to 60_000 
Signed-off-by: Nicolas Arnold <nic@roadie.io>
 2022-02-25 13:56:48 +00:00
Nicolas Arnold d6deb5e440 Set timeout for scaffolder octokit client 
If a client fails to contact github (or the network connectivity is bad), there is no reasonible timeout for the Octokit client.

This change here adds a default timeout of 60 seconds

Here is a link to the octokit type definition: https://github.com/octokit/types.ts/blob/master/src/RequestRequestOptions.ts

Signed-off-by: Nicolas Arnold <nic@roadie.io>
 2022-02-25 13:35:13 +00:00
Johan Haals f2210717d1 Merge pull request #9807 from backstage/jhaals/scaffolder-backend-cleanup 
scaffolder-backend: clenaup api report
 2022-02-25 11:53:29 +01:00
Johan Haals 7372f29473 scaffolder-backend: clenaup api report 
Signed-off-by: Johan Haals <johan.haals@gmail.com>
 2022-02-25 11:25:27 +01:00
Patrick Jungermann 8119a9e011 fix(scaffolder,bitbucket): support custom defaultBranch for Bitbucket Cloud 
Before this change, the returned `repoContentsUrl` of this scaffolder action
was hardcoded to branch `master` which is the default value for `defaultBranch`.

The change will ensure to use the provided value instead.

Closes: #9759

Signed-off-by: Patrick Jungermann <Patrick.Jungermann@gmail.com>
 2022-02-25 11:20:13 +01:00
blam 4cd2787846 chore: update the changeset in main for the emergency release 
Signed-off-by: blam <ben@blam.sh>
 2022-02-25 08:16:42 +01:00
Phil Kuang c7f6424a26 fix(githubPrAction): properly construct repoUrl 
Signed-off-by: Phil Kuang <pkuang@factset.com>
 2022-02-24 16:17:38 -05:00
github-actions[bot] c9da151d84 Version Packages 2022-02-24 13:54:37 +00:00
blam 91c6faeb7b chore: updated with review comments 
Signed-off-by: blam <ben@blam.sh>
 2022-02-24 14:14:58 +01:00
blam 4031764fca chore: updating to use templateRef 
Signed-off-by: blam <ben@blam.sh>
 2022-02-24 14:01:51 +01:00
Fredrik Adelöw fc07c8c132 Merge pull request #9754 from backstage/freben/the-ref-revolution 
Remove all usage of, and deprecate, `EntityRef`
 2022-02-23 15:34:08 +01:00
Fredrik Adelöw c37252f2ae Merge pull request #9663 from backstage/rugvip/moveloco 
catalog-model: move LocationSpec to catalog-backend
 2022-02-23 15:15:50 +01:00
Fredrik Adelöw 76e3cb1153 fix tests 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
 2022-02-23 14:33:35 +01:00
Fredrik Adelöw 3f480db963 stop using EntityRef in scaffolder-backend 
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
 2022-02-23 12:01:27 +01:00
Ben Lambert 4e709aaecd Merge pull request #9727 from backstage/blam/migrations/scaffolder-backend/last 
🧹 More Deprecations and Breaking Changes to `plugin-scaffolder-backend`
 2022-02-22 16:31:56 +01:00
blam 4165cc0ce4 chore: the last of the migrations 
Signed-off-by: blam <ben@blam.sh>
 2022-02-22 16:09:44 +01:00
blam b5a65f9946 chore: rebuild api-reports 
Signed-off-by: blam <ben@blam.sh>
 2022-02-22 14:33:42 +01:00
blam 67771d2b21 chore: remove the observe method in favour of an observable 
Signed-off-by: blam <ben@blam.sh>
 2022-02-22 14:31:20 +01:00
Ben Lambert 53dbebbcde Merge pull request #9701 from backstage/blam/deprecations/octokit 
deprecations: Deprecate the `OctokitProvider` export from `scaffolder-backend`
 2022-02-22 13:38:32 +01:00
blam dbe239808d chore: encodeURIComponent 
Signed-off-by: blam <ben@blam.sh>
diff --git c/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts i/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts
index ca70084ef5..9efc11210a 100644
--- c/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts
+++ i/plugins/scaffolder-backend/src/scaffolder/actions/builtin/publish/githubPullRequest.ts
@@ -65,10 +65,14 @@ export const defaultClientFactory = async ({
   host = 'github.com',
   token: providedToken,
 }: ClientFactoryInput): Promise<PullRequestCreator> => {
+  const [encodedHost, encodedOwner, encodedRepo] = [host, owner, repo].map(
+    encodeURIComponent,
+  );
+
   const octokitOptions = await getOctokitOptions({
     integrations,
     credentialsProvider: githubCredentialsProvider,
-    repoUrl: `https://${host}/${owner}/${repo}`,
+    repoUrl: `https://${encodedHost}/${encodedOwner}/${encodedRepo}`,
     token: providedToken,
   });
 2022-02-22 13:10:39 +01:00
blam 1bb1022908 chore: removing the rexports 
Signed-off-by: blam <ben@blam.sh>
 2022-02-22 12:45:56 +01:00
blam 48c0316f3e chore: add type option for emitLogEvent 
Signed-off-by: blam <ben@blam.sh>
 2022-02-22 12:28:19 +01:00
blam 8142c09b3f chore: wth prettier 
Signed-off-by: blam <ben@blam.sh>
 2022-02-22 11:29:35 +01:00
blam 5b7079a696 chore review comments 
Signed-off-by: blam <ben@blam.sh>

Signed-off-by: blam <ben@blam.sh>
 2022-02-21 20:52:27 +01:00
Patrik Oldsberg ed09ad8093 catalog-model: move LocationSpec to catalog-backend 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-02-21 18:53:13 +01:00
blam 5042a822f6 chore: fix auth provided 
Signed-off-by: blam <ben@blam.sh>
 2022-02-21 16:08:16 +01:00
blam 1a864a3b68 chore: updating the api report 
Signed-off-by: blam <ben@blam.sh>
 2022-02-21 15:57:18 +01:00
blam 9553964f28 chore: providing a new helper for generating octokit credentialsProvider 
Signed-off-by: blam <ben@blam.sh>
 2022-02-21 15:41:30 +01:00
blam afee525a36 chore: deprecating the OctokitProvider 
Signed-off-by: blam <ben@blam.sh>
 2022-02-21 15:40:38 +01:00
blam 65a7939c6c deprecations: more scaffolder backend stuff 
Signed-off-by: blam <ben@blam.sh>
 2022-02-18 19:07:08 +01:00
blam 756f6cc5ef chore: added some more deprecations and fixing some more of the api-report 
Signed-off-by: blam <ben@blam.sh>
 2022-02-18 16:22:18 +01:00
blam e21755c639 chore: tidying up the fetchContents types 
Signed-off-by: blam <ben@blam.sh>
 2022-02-18 16:17:23 +01:00
blam 253bd2081c chore: deprecating the fetch:cookiecutter being installed by default 
Signed-off-by: blam <ben@blam.sh>
 2022-02-18 16:09:20 +01:00
Ben Lambert 3c1c6f55b9 chore: code review comments 
Signed-off-by: Ben Lambert <blam@spotify.com>

Co-authored-by: Fredrik Adelöw <freben@gmail.com>
 2022-02-18 14:25:47 +01:00
blam 7f193ff019 chore: fix the types and update the api-report 
Signed-off-by: blam <ben@blam.sh>
 2022-02-18 13:40:22 +01:00
blam a7e01ab339 make some breaking changes to TaskStore and TaskBroker 
Signed-off-by: blam <ben@blam.sh>
 2022-02-18 13:34:28 +01:00
blam 3cdd27b4c7 chore: renaming some types that are exported and moving across 
Signed-off-by: blam <ben@blam.sh>
 2022-02-18 13:13:31 +01:00
blam 0988c86166 chore: constructor for DatabaseTaskStore is now private 
Signed-off-by: blam <ben@blam.sh>
 2022-02-18 13:03:53 +01:00
Ben Lambert db7157ad50 Merge pull request #9573 from backstage/blam/deprecations/metadata 
deprecations: Some deprecations for the `specs` in `scaffolder-common`
 2022-02-18 11:36:38 +01:00
Patrik Oldsberg ba68ea4450 apply 0.68.1 fixes to master 
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
 2022-02-18 11:30:15 +01:00
blam f65b60d101 chore: fixing broken tests 
Signed-off-by: blam <ben@blam.sh>
 2022-02-18 10:54:44 +01:00
Johan Haals df61ca71dd catalog-backend: Require impl of getProcessorName in CatalogProcessor 
Signed-off-by: Johan Haals <johan.haals@gmail.com>
 2022-02-17 14:54:32 +01:00
blam bab8027029 chore: reworking the templateInfo type 
Signed-off-by: blam <ben@blam.sh>
 2022-02-17 14:22:06 +01:00