Commit Graph

255 Commits

Author SHA1 Message Date
Emma Indal af4980fb5d [Search] SearchBar Analytics tracking (#8656)
* test capture search bar events

Signed-off-by: Emma Indal <emmai@spotify.com>

* capture search bar events

Signed-off-by: Emma Indal <emmai@spotify.com>

* only run onChange method if provided, otherwise set term

Signed-off-by: Emma Indal <emmai@spotify.com>

* changeset

Signed-off-by: Emma Indal <emmai@spotify.com>

* unconditionally call analytics API

Signed-off-by: Emma Indal <emmai@spotify.com>

* update changeset to be less specific to GA

Signed-off-by: Emma Indal <emmai@spotify.com>

* move analytics tracking to SearchBarBase

Signed-off-by: Emma Indal <emmai@spotify.com>

* add search to key events

Signed-off-by: Emma Indal <emmai@spotify.com>

* capture types as analytics context attribute, only for SearchBar

Signed-off-by: Emma Indal <emmai@spotify.com>

* move AnalyticsContext to within SearchContextProvider

Signed-off-by: Emma Indal <emmai@spotify.com>

* refactor search tracking out to its own component

Signed-off-by: Emma Indal <emmai@spotify.com>

* captures not only google analytics

Signed-off-by: Emma Indal <emmai@spotify.com>
2021-12-29 14:10:01 +01:00
Eric Peterson a6bc757a45 Review notes.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2021-12-29 11:54:30 +01:00
Eric Peterson f4896c495c Merge branch 'master' into feat/search-facet-by-type
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2021-12-29 10:43:33 +01:00
Eric Peterson eeb2269bb9 Add basic tests for <SearchType.Accordion />
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2021-12-28 17:08:01 +01:00
Eric Peterson dd95ac91cc Refactor search plugin stories to use a shared mock search context provider.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2021-12-28 16:11:05 +01:00
Fredrik Adelöw 6d8e3a9651 Internal cleanup of the exports structure in the search plugin
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-12-28 15:18:35 +01:00
Eric Peterson 627b98ac07 <SearchTypeFacet /> -> <SearchType.Accordion />
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2021-12-28 11:34:03 +01:00
Eric Peterson 8b532a6c02 Initial SearchTypeFacet implementation.
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
2021-12-27 18:40:20 +01:00
github-actions[bot] 3d68c45ef7 Version Packages 2021-12-23 12:23:34 +00:00
Camila Belo 49a696d720 [Search] Standardizes input search components (#8532)
* refactor(plugin-search): customize search bar components

Signed-off-by: Camila Belo <camilaibs@gmail.com>

* refactor(plugin-search): use search bar in search modal

Signed-off-by: Camila Belo <camilaibs@gmail.com>

* refactor(plugin-search): customize home page search bar

Signed-off-by: Camila Belo <camilaibs@gmail.com>

* chore(plugin-search): update api reports

Signed-off-by: Camila Belo <camilaibs@gmail.com>

* chore: add changeset file

Signed-off-by: Camila Belo <camilaibs@gmail.com>

* apply review suggestions

Signed-off-by: Camila Belo <camilaibs@gmail.com>

* increase default debounceTime and remove prop from SearchBar in SearchModal + SearchPage in app

Signed-off-by: Emma Indal <emmai@spotify.com>

* update test using default debounce time

Signed-off-by: Emma Indal <emmai@spotify.com>

* add changeset for create-app

Signed-off-by: Emma Indal <emmai@spotify.com>

* fix exports after rebase

Signed-off-by: Emma Indal <emmai@spotify.com>

Co-authored-by: Emma Indal <emmai@spotify.com>
2021-12-23 12:05:26 +01:00
Fredrik Adelöw d0523cec56 Merge pull request #8156 from WarlenRodrigues/fixing_link_somponents_usage
Fixed Link components usage. Now, all links use the Backstage's Link c…
2021-12-21 08:10:15 +01:00
Fredrik Adelöw d4aeaa8461 Merge pull request #8488 from cmpadden/remove-deprecations
Remove Deprecations (release-2021-01-28, 2021-06-01, 2021-10-28, 2021-11-18)
2021-12-21 08:08:02 +01:00
WarlenRodrigues 22bf2da934 Fied Link components usage. Now, all links use the Backstage's Link component
Signed-off-by: WarlenRodrigues <warlen.cesarrodrigues@gmail.com>
2021-12-20 19:18:04 +01:00
Fredrik Adelöw 4fbff018de Merge pull request #8443 from dehamzah/export-props-icon-in-sidebarsearch
Export Icon Props for SidebarSearch and SidebarSearchModal Component
2021-12-20 16:35:59 +01:00
Fredrik Adelöw 7eeb65fd77 fix review comments
Signed-off-by: Fredrik Adelöw <freben@gmail.com>
2021-12-20 16:06:16 +01:00
Colton Padden 345dcea560 release-2021-06-01 packages/core-plugin-api/src/apis/system/ApiRef.ts:27
Signed-off-by: Colton Padden <colton.padden@fastmail.com>
2021-12-17 15:04:34 -05:00
Dede Hamzah 8e9d7e9200 Exporting the type
Signed-off-by: Dede Hamzah <dehamzah@gmail.com>
2021-12-16 16:31:54 +07:00
github-actions[bot] ef6a039e07 Version Packages 2021-12-16 08:56:38 +00:00
Dede Hamzah dd480029ec Export icon props for SidebarSearchModal Component
Signed-off-by: Dede Hamzah <dehamzah@gmail.com>
2021-12-10 17:55:18 +07:00
Dede Hamzah 71dc1bba1c export SidebarSearchProps
Signed-off-by: Dede Hamzah <dehamzah@gmail.com>
2021-12-10 17:36:17 +07:00
Dede Hamzah 13d8c6c94b Export icon props in SidebarSearch component
Signed-off-by: Dede Hamzah <dehamzah@gmail.com>
2021-12-10 10:53:46 +07:00
github-actions[bot] 9068128fd8 Version Packages 2021-12-09 12:02:28 +00:00
Johan Haals dd77b5eb12 Merge pull request #8283 from backstage/mob/identity-api
core-plugin-api: stabilize IdentityApi
2021-12-08 14:29:03 +01:00
Patrik Oldsberg b191e1737a packages,plugins: avoid usage of react-dom in tests
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-12-07 17:40:51 +01:00
Patrik Oldsberg 39c64f5035 packages,plugins: move @types/react to peer deps and sync query with react
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-12-07 17:38:44 +01:00
Patrik Oldsberg be32bc3edb package,plugins: move react to peer deps and include v17
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-12-07 17:38:14 +01:00
Johan Haals a05e7081b8 Merge pull request #8247 from backstage/changeset-release/master
Version Packages
2021-12-02 14:30:13 +01:00
Emma Indal 382e3a94b3 [Search] export search api interface (#8334)
* export api interface from plugin

Signed-off-by: Emma Indal <emmai@spotify.com>

* add changeset

Signed-off-by: Emma Indal <emmai@spotify.com>

* export as type

Signed-off-by: Emma Indal <emmai@spotify.com>

* update api reports

Signed-off-by: Emma Indal <emmai@spotify.com>
2021-12-02 14:26:32 +01:00
github-actions[bot] 29f2606ed9 Version Packages 2021-12-02 12:35:24 +00:00
Johan Haals e9471d274c Use BackstageUserIdentity, fix tests
Co-authored-by: blam <ben@blam.sh>
Co-authored-by: Fredrik Adelöw <freben@gmail.com>
Co-authored-by: Patrik Oldsberg <poldsberg@gmail.com>
Signed-off-by: Johan Haals <johan.haals@gmail.com>
2021-12-02 13:32:35 +01:00
Ben Lambert afa656ae6b Merge pull request #8302 from backstage/feat/search-modal-context
[Search] Search Modal now relies on the Search Context
2021-12-02 13:08:51 +01:00
Camila Belo d11fb7fe04 refactor(search): use callback hook on the modal toggle
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2021-12-02 11:36:26 +01:00
Camila Belo 873bb2618c docs(search): build api reports
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2021-12-01 17:38:18 +01:00
Camila Belo 662636227b feat(search): move the modal state to context
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2021-12-01 17:38:17 +01:00
Camila Belo 3be6234592 docs(search): build api reports
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2021-12-01 17:14:54 +01:00
Camila Belo 00da5bfca7 feat(search): add optional icon and secondary action for default result items
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2021-12-01 17:05:28 +01:00
Camila Belo 11e2673594 docs(search): build api reports
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2021-12-01 15:33:33 +01:00
Camila Belo 9c19328da9 feat(search): Add optional clear button prop
Co-authored-by: Emma Indal <emma.indahl@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
2021-12-01 15:33:13 +01:00
github-actions[bot] ef34f5de7b Version Packages 2021-11-25 12:40:52 +00:00
Patrik Oldsberg 8a96019a39 Merge branch 'master' into rugvip/test-port 2021-11-22 17:33:10 +01:00
Patrik Oldsberg 0fae9f2c0b core-app-api: fix and release accidental createApp type breakage
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-18 22:54:46 +01:00
github-actions[bot] 99bf179ccf Version Packages 2021-11-18 11:52:08 +00:00
Patrik Oldsberg 29ef695410 packages,plugins: migrate to using TestApiProvider and Registry
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
2021-11-18 11:28:46 +01:00
blam 06065c6003 chore: fixed better namespacing for the routeRefs
Signed-off-by: blam <ben@blam.sh>
2021-11-17 20:43:14 +01:00
blam 1332a98a01 chore: fixing deprecation warnings for all the things that are in the monorepo
Signed-off-by: blam <ben@blam.sh>
2021-11-17 20:24:20 +01:00
Eric Peterson 1c2961bc0b Merge pull request #7946 from backstage/emmaindal/search-modal-storybook 2021-11-17 19:07:34 +01:00
Emma Indal 28b34419e4 api reports and changeset update
Signed-off-by: Emma Indal <emmai@spotify.com>
2021-11-17 17:43:18 +01:00
Emma Indal b02a698947 use material-uis autoFocus prop as an option, not default
Signed-off-by: Emma Indal <emmai@spotify.com>
2021-11-17 17:18:42 +01:00
Emma Indal 45f3a67c4c add focused prop to both SearchBar and SearchBarBase components + storybook example
Signed-off-by: Emma Indal <emmai@spotify.com>
2021-11-12 12:39:31 +01:00
github-actions[bot] 3369ade8c0 Version Packages 2021-11-11 11:07:58 +00:00